From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH net-next 1/2] doc: sfp-phylink: drop the mention to phylink_config->pcs_poll
Date: Mon, 26 Feb 2024 16:02:36 +0100 [thread overview]
Message-ID: <20240226160236.20c0be97@device-28.home> (raw)
In-Reply-To: <Zdx40zi1Qz61sCX7@shell.armlinux.org.uk>
Hi Russell,
On Mon, 26 Feb 2024 11:41:07 +0000
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
> On Tue, Feb 20, 2024 at 05:04:03PM +0100, Maxime Chevallier wrote:
> > commit 64b4a0f8b51b ("net: phylink: remove phylink_config's pcs_poll")
> > dropped the phylink_config->pcs_poll field, which is no longer required
> > to be set by MAC drivers. Remove that mention in the phylink porting
> > guide.
>
> The porting guide needs to be updated with the PCS, and the details for
> that moved over rather than being deleted. While it's true that this
> member is gone from phylink_config, it was only removed after the
> introduction of the similarly named member in phylink_pcs.
>
> In other words, point 10 should probably read:
>
> 10. Arrange for PCS link state interrupts to be forwarded into
> phylink, via:
>
> .. code-block:: c
>
> phylink_pcs_change(pcs, link_is_up);
>
> where ``link_is_up`` is true if the link is currently up or false
> otherwise. If a PCS is unable to provide these interrupts, then
> it should set ``pcs->pcs_poll = true;`` when creating the PCS.
>
> However, for that to make sense, we then need the guide to provide
> details about creating the PCS, and also the mac_select_pcs() method.
> Thus my comment about a much bigger update being required.
>
Makes sense. If that's OK I'll send a V2 with a PCS handling addition
to it, and see how that looks.
Thanks for the review,
Maxime
next prev parent reply other threads:[~2024-02-26 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 16:04 [PATCH net-next 0/2] doc: sfp-phylink: update the porting guide Maxime Chevallier
2024-02-20 16:04 ` [PATCH net-next 1/2] doc: sfp-phylink: drop the mention to phylink_config->pcs_poll Maxime Chevallier
2024-02-26 11:41 ` Russell King (Oracle)
2024-02-26 15:02 ` Maxime Chevallier [this message]
2024-02-20 16:04 ` [PATCH net-next 2/2] doc: sfp-phylink: mention the mac_capabilities and supported_interfaces Maxime Chevallier
2024-02-26 11:45 ` Russell King (Oracle)
2024-02-26 15:07 ` Maxime Chevallier
2024-02-26 11:01 ` [PATCH net-next 0/2] doc: sfp-phylink: update the porting guide Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226160236.20c0be97@device-28.home \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).