From: Rob Herring <robh@kernel.org>
To: "Paweł Anikiel" <panikiel@google.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
airlied@gmail.com, akpm@linux-foundation.org,
conor+dt@kernel.org, daniel@ffwll.ch, dinguyen@kernel.org,
hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org,
maarten.lankhorst@linux.intel.com, mchehab@kernel.org,
mripard@kernel.org, tzimmermann@suse.de,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
chromeos-krk-upstreaming@google.com, ribalda@chromium.org
Subject: Re: [PATCH v2 8/9] media: dt-bindings: Add Intel Displayport RX IP
Date: Tue, 27 Feb 2024 08:24:40 -0600 [thread overview]
Message-ID: <20240227142440.GA3863852-robh@kernel.org> (raw)
In-Reply-To: <CAM5zL5rs4JyFznnWDLZP_2jwnX+yc+OwwOijGZGsQK+WtpiWKA@mail.gmail.com>
On Tue, Feb 27, 2024 at 02:11:27PM +0100, Paweł Anikiel wrote:
> On Mon, Feb 26, 2024 at 6:29 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 26/02/2024 13:43, Paweł Anikiel wrote:
> > >>>>> + intel,max-stream-count:
> > >>>>> + $ref: /schemas/types.yaml#/definitions/uint32
> > >>>>> + description: Max stream count configuration parameter
> > >>>>> +
> > >>>>> + port:
> > >>>>> + $ref: /schemas/graph.yaml#/properties/port
> > >>>>> + description: SST main link
> > >>>>
> > >>>> I don't understand why you have both port and ports. Shouldn't this be
> > >>>> under ports?
> > >>>
> > >>> I put both so that you can use the shorter port property when the
> > >>> device only has one port (i.e. no MST support). It would work fine
> > >>> without it. If you think that's unnecessary, I can remove it (and use
> > >>> the ports property even if there is only one).
> > >>
> > >> No, it is fine, but then you need allOf: which will restrict to only one
> > >> of them: either port or ports.
> > >
> > > There already is an allOf below that says that ports is required for
> > > MST support and port is required otherwise. Isn't this enough?
> >
> > Add both port and ports and see if it is enough.
>
> Ok, I see. I tried and this seems to work:
>
> oneOf:
> - required:
> - port
> - required:
> - ports
>
> And that would make the if/else with port and ports below not needed.
> What do you think?
Just always use 'ports' rather than complicate things.
Rob
next prev parent reply other threads:[~2024-02-27 14:24 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 16:02 [PATCH v2 0/9] Add Chameleon v3 video support Paweł Anikiel
2024-02-21 16:02 ` [PATCH v2 1/9] media: v4l2-subdev: Add a pad variant of .query_dv_timings() Paweł Anikiel
2024-02-28 11:25 ` Hans Verkuil
2024-02-28 15:34 ` Paweł Anikiel
2024-02-29 8:02 ` Hans Verkuil
2024-02-29 11:33 ` Paweł Anikiel
2024-02-29 12:05 ` Hans Verkuil
2024-02-21 16:02 ` [PATCH v2 2/9] media: Add Chameleon v3 framebuffer driver Paweł Anikiel
2024-02-28 11:24 ` Hans Verkuil
2024-02-28 15:08 ` Paweł Anikiel
2024-02-28 15:14 ` Hans Verkuil
2024-02-21 16:02 ` [PATCH v2 3/9] drm/dp_mst: Move DRM-independent structures to separate header Paweł Anikiel
2024-02-21 16:02 ` [PATCH v2 4/9] lib: Move DisplayPort CRC functions to common lib Paweł Anikiel
2024-02-21 16:02 ` [PATCH v2 5/9] drm/display: Add mask definitions for DP_PAYLOAD_ALLOCATE_* registers Paweł Anikiel
2024-02-21 16:02 ` [PATCH v2 6/9] media: intel: Add Displayport RX IP driver Paweł Anikiel
2024-02-28 12:11 ` Hans Verkuil
2024-02-21 16:02 ` [PATCH v2 7/9] media: dt-bindings: Add Chameleon v3 framebuffer Paweł Anikiel
2024-02-26 9:10 ` Krzysztof Kozlowski
2024-04-23 17:00 ` Paweł Anikiel
2024-02-21 16:02 ` [PATCH v2 8/9] media: dt-bindings: Add Intel Displayport RX IP Paweł Anikiel
2024-02-26 9:12 ` Krzysztof Kozlowski
2024-02-26 10:59 ` Paweł Anikiel
2024-02-26 12:06 ` Krzysztof Kozlowski
2024-02-26 12:43 ` Paweł Anikiel
2024-02-26 17:29 ` Krzysztof Kozlowski
2024-02-27 13:11 ` Paweł Anikiel
2024-02-27 14:24 ` Rob Herring [this message]
2024-02-27 14:29 ` Rob Herring
2024-02-28 11:05 ` Paweł Anikiel
2024-02-28 12:18 ` Krzysztof Kozlowski
2024-02-28 13:09 ` Paweł Anikiel
2024-02-28 18:09 ` Rob Herring
2024-02-29 10:25 ` Paweł Anikiel
2024-03-01 16:26 ` Rob Herring
2024-02-21 16:02 ` [PATCH v2 9/9] ARM: dts: chameleonv3: Add video device nodes Paweł Anikiel
2024-02-26 9:15 ` Krzysztof Kozlowski
2024-02-26 11:09 ` Paweł Anikiel
2024-02-26 12:07 ` Krzysztof Kozlowski
2024-02-26 12:27 ` Paweł Anikiel
2024-02-26 17:30 ` Krzysztof Kozlowski
2024-02-27 11:26 ` Paweł Anikiel
2024-02-23 19:04 ` [PATCH v2 0/9] Add Chameleon v3 video support Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227142440.GA3863852-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chromeos-krk-upstreaming@google.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=panikiel@google.com \
--cc=ribalda@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).