From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9237B4879E for ; Thu, 29 Feb 2024 08:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709194870; cv=none; b=sEGxAUVLXso6tGAZ5qMAO0kg7DNqHsaoq82B7hG9hSh+JMSa/J9I34R3j2OJpjV2+nPQLEtUHjJ3V3pDEDt3qWDHCbEm4n5qL1rLUDJ4z6bU0Ntie+rcevv7TeZtQnx+eXj4EDN+X0xjeNmyQq1jYAsg5zZSWH0x9uFWTdspFVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709194870; c=relaxed/simple; bh=rKNBuW8y42BsiMkdbpdNnHpLhtnB04eGCNz7vyIXnxw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XOXy09lbEw1vYVvTW1nknrZGoTahikW/Fkdnay1PUbJzgVjdJEXD6m51zGtsU3rMdHQbYZqu5pzbUUFPfadqHd8tK/T5SuznlEm3z7+JQTbatkknDhlGf1Fix2wahgxgUa45KprbqkQLyAcNNnKjQr2JlS0pSzA7wPJrKWsHBxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QczWfHG9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QczWfHG9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8947EC433C7; Thu, 29 Feb 2024 08:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709194870; bh=rKNBuW8y42BsiMkdbpdNnHpLhtnB04eGCNz7vyIXnxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QczWfHG9UEVVneRoWGMmkbXgEyytmMYUnY0vq0Xqa8LEOaqYopuX3t2SOmx7tPnDi 5ErLtcwULad5ImD9cSc4VNAJzeV3kNE8fII3cTAArBCbP36gk/RxzeSFDG2afemaNA ljXEtuBQ4OWfw0NLheod+v/Ji13oBMpOGFCuzPyl7JBbST1xFwYtWpADLaW5H+LP1v 9fIrYihed70QhFj1yY+USRvi7MnuZG+nDGlJSKqu74xfZWMilc1RZpZojpMF0DTRaj iwIEP/We2Cz54zhMj2sBh6YU1/UtQwwVjM418FIOd3qck6jUe2XsGzb7wb673WJGt7 9BtH7SEABSIpg== Date: Thu, 29 Feb 2024 09:21:07 +0100 From: Maxime Ripard To: "Klymenko, Anatoliy" Cc: Laurent Pinchart , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , "Simek, Michal" , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/4] drm/atomic-helper: Add select_output_bus_format callback Message-ID: <20240229-crane-of-eternal-joy-f675d7@houat> References: <20240226-dp-live-fmt-v1-0-b78c3f69c9d8@amd.com> <20240226-dp-live-fmt-v1-4-b78c3f69c9d8@amd.com> <20240228-nifty-flashy-shrew-905edc@houat> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rs5ri76nt4anyhzn" Content-Disposition: inline In-Reply-To: --rs5ri76nt4anyhzn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Feb 28, 2024 at 10:00:19PM +0000, Klymenko, Anatoliy wrote: > > > diff --git a/include/drm/drm_modeset_helper_vtables.h > > > b/include/drm/drm_modeset_helper_vtables.h > > > index 881b03e4dc28..7c21ae1fe3ad 100644 > > > --- a/include/drm/drm_modeset_helper_vtables.h > > > +++ b/include/drm/drm_modeset_helper_vtables.h > > > @@ -489,6 +489,37 @@ struct drm_crtc_helper_funcs { > > > bool in_vblank_irq, int *vpos, int *hpos, > > > ktime_t *stime, ktime_t *etime, > > > const struct drm_display_mode *mode); > > > + > > > + /** > > > + * @select_output_bus_format > > > + * > > > + * Called by the first connected DRM bridge to negotiate input media > > > + * bus format. CRTC is expected to pick preferable media formats fr= om > > > + * the list supported by the DRM bridge chain. > >=20 > > There's nothing restricting it to bridges here. Please rephrase this to= remove the > > bridge mention. The user is typically going to be the encoder, and brid= ges are just > > an automagic implementation of an encoder. > >=20 >=20 > OK. I'll fix than in the next version. >=20 > > And generally speaking, I'd really like to have an implementation avail= able before > > merging this. > > >=20 > Well, 2 instances of this callback implementations exist as drafts, as > this is the new API. A little bit of a chicken and egg problem. I'll > try to groom at least one of them into upstreamable shape and attach > it to the patch set. That's totally what I meant :) I basically don't want to have an interface that isn't used. If you provide an implementation in the same series, it's totally reasonable Maxime --rs5ri76nt4anyhzn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZeA+cgAKCRDj7w1vZxhR xQLtAP9/fGoxq0DXjo7CwyIuSIvVRUO1zC+/mQvsS2T+X6Z0gQD/aTj1xrt+ImK+ u6CAeB4rSGry8XnZlOByE/CzK+HDXwM= =dkG1 -----END PGP SIGNATURE----- --rs5ri76nt4anyhzn--