From: Clayton Craft <clayton@craftyguy.net>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
stable@vger.kernel.org,
Janaki Ramaiah Thota <quic_janathot@quicinc.com>
Subject: Re: [PATCH] Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT"
Date: Thu, 14 Mar 2024 10:01:03 -0700 [thread overview]
Message-ID: <20240314100103.GC6100@craftyguy.net> (raw)
In-Reply-To: <20240314084412.1127-1-johan+linaro@kernel.org>
On Thu, 14 Mar 2024 09:44:12 +0100 Johan Hovold <johan+linaro@kernel.org> wrote:
> This reverts commit 7dcd3e014aa7faeeaf4047190b22d8a19a0db696.
>
> Qualcomm Bluetooth controllers like WCN6855 do not have persistent
> storage for the Bluetooth address and must therefore start as
> unconfigured to allow the user to set a valid address unless one has
> been provided by the boot firmware in the devicetree.
>
> A recent change snuck into v6.8-rc7 and incorrectly started marking the
> default (non-unique) address as valid. This specifically also breaks the
> Bluetooth setup for some user of the Lenovo ThinkPad X13s.
>
> Note that this is the second time Qualcomm breaks the driver this way
> and that this was fixed last year by commit 6945795bc81a ("Bluetooth:
> fix use-bdaddr-property quirk"), which also has some further details.
>
> Fixes: 7dcd3e014aa7 ("Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT")
> Cc: stable@vger.kernel.org # 6.8
> Cc: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Thanks Johan, this revert does indeed fix Bluetooth for me on the X13s.
Reported-by: Clayton Craft <clayton@craftyguy.net>
Tested-by: Clayton Craft <clayton@craftyguy.net>
-Clayton
next prev parent reply other threads:[~2024-03-14 17:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 8:44 [PATCH] Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT" Johan Hovold
2024-03-14 14:30 ` Luiz Augusto von Dentz
2024-03-14 15:07 ` Johan Hovold
2024-03-25 13:57 ` Linux regression tracking (Thorsten Leemhuis)
2024-03-25 17:10 ` Luiz Augusto von Dentz
2024-03-25 17:24 ` Johan Hovold
2024-03-25 19:39 ` Luiz Augusto von Dentz
2024-03-25 19:48 ` Johan Hovold
2024-03-25 20:07 ` Luiz Augusto von Dentz
2024-03-25 20:14 ` Johan Hovold
2024-03-25 20:31 ` Luiz Augusto von Dentz
2024-03-26 7:09 ` Johan Hovold
2024-03-26 14:17 ` Luiz Augusto von Dentz
2024-03-26 15:18 ` Johan Hovold
2024-03-26 16:20 ` Johan Hovold
2024-03-26 16:58 ` Luiz Augusto von Dentz
2024-03-26 17:08 ` Johan Hovold
2024-03-14 17:01 ` Clayton Craft [this message]
2024-03-26 15:30 ` patchwork-bot+bluetooth
2024-03-28 14:55 ` Janaki Ramaiah Thota
2024-03-28 15:23 ` Johan Hovold
2024-03-29 7:25 ` Janaki Ramaiah Thota
2024-04-03 12:24 ` Johan Hovold
2024-04-05 12:59 ` Janaki Ramaiah Thota
2024-04-15 10:52 ` Janaki Ramaiah Thota
2024-04-15 11:20 ` Johan Hovold
2024-04-16 9:20 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314100103.GC6100@craftyguy.net \
--to=clayton@craftyguy.net \
--cc=johan+linaro@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_janathot@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).