From: David Sterba <dsterba@suse.cz>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Christian Brauner <brauner@kernel.org>
Cc: Anand Jain <anand.jain@oracle.com>,
David Sterba <dsterba@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Christian Brauner <brauner@kernel.org>
Subject: Re: linux-next: build failure after merge of the btrfs-fixes tree
Date: Mon, 18 Mar 2024 18:31:00 +0100 [thread overview]
Message-ID: <20240318173100.GD16737@suse.cz> (raw)
In-Reply-To: <20240318091755.1d0f696f@canb.auug.org.au>
On Mon, Mar 18, 2024 at 09:17:55AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
> fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
> 1413 | if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
> | ^~~~~~~~~~~
> fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
> cc019bc0d55b ("btrfs: do not skip re-registration for the mounted device")
>
> I have used the btrfs-fixes tree from next-20240315 for today.
>
> This is actually caused by an interaction with commit
>
> 9ae061cf2a46 ("btrfs: port device access to file")
>
> which has been in Linus' tree since March 12 (and linux-next since Feb 26).
I would really appreciate if all infrastructure changes to btrfs code
have CC:linux-btrfs@, the whole series "Open block devices as files" has
never been CCed so the build breakage is noticed only by accident. Also
I wonder why I have to repeatedly ask for that and why people think that
doing broad changes to code maintained by somebody else is ok.
There are 26 patches in linux-next intersecting fs/btrfs most of which I
see for the first time now. I don't have time to read fsdevel@ regularly
and act rather on events (i.e. CC or mails).
VFS is in the center of many other subsystems I understand that adding
the CC: manually is not feasible but scripting "if $path add CC:$subsys"
should be doable, namely when it's not just one-time job. Please try to
find some middle ground between efforts and patch workflow sanity.
Thanks for understanding.
next prev parent reply other threads:[~2024-03-18 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 22:17 linux-next: build failure after merge of the btrfs-fixes tree Stephen Rothwell
2024-03-18 4:50 ` Anand Jain
2024-03-18 17:31 ` David Sterba [this message]
2024-03-18 18:58 ` David Sterba
[not found] <20200107082431.2b83a8ac@canb.auug.org.au>
2020-01-07 15:22 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318173100.GD16737@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=brauner@kernel.org \
--cc=dsterba@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).