From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 806B01B28D; Tue, 26 Mar 2024 17:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711473292; cv=none; b=m9ou40ZaLSjpsR0tu0ICsIHf5679acUZllwV/q25C14fbEgPNfzQX8UJiu5IBBoH98g0LHbQlhVZ7FSXgW0heDH7I/1mwf017jChf9althN9mwgAPCYnQZgSAxW/3U4aAYJZkwS2laNwj99SW9J0SxkOzg3/BWsS+cOeyuWOfBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711473292; c=relaxed/simple; bh=NI17FeW0Q8sWFev8QwGIWlqd+9TikmhqsHuwJEWouZg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l+d8QPEcAQtqla6Kn75FfVRgaeaJPxBDMqkgLTU7Ti9H7LdXQFHbzxSa/rUUEvMLvzziqFgDaXnnDokw3cFNPrRLeebyw33noWhUR2c20vEl/iaG/sHbT6dAaz7vx1hJtVaE/5M8Y+aC4t/yFYmjB7shOH2quAYSqWyi29iD8XQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D96A2F4; Tue, 26 Mar 2024 10:15:23 -0700 (PDT) Received: from e130802.arm.com (e130802.arm.com [10.1.39.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B3213F64C; Tue, 26 Mar 2024 10:14:47 -0700 (PDT) Date: Tue, 26 Mar 2024 17:14:38 +0000 From: Abdellatif El Khlifi To: Mathieu Poirier Cc: Abdellatif El Khlifi , Sudeep Holla , Bjorn Andersson , Rob Herring , Liviu Dudau , Lorenzo Pieralisi , Krzysztof Kozlowski , Conor Dooley , Drew.Reed@arm.com, Adam.Johnston@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver Message-ID: <20240326171438.GA56238@e130802.arm.com> References: <20240311114442.GA82865@e130802.arm.com> <20240312173252.GA38992@e130802.arm.com> <20240313171756.GA82165@e130802.arm.com> <20240325171339.GA368569@e130802.arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Mathieu, > > > > > > > > > > This is an initial patchset for allowing to turn on and off the remote processor. > > > > > > > > > > The FW is already loaded before the Corstone-1000 SoC is powered on and this > > > > > > > > > > is done through the FPGA board bootloader in case of the FPGA target. Or by the Corstone-1000 FVP model > > > > > > > > > > (emulator). > > > > > > > > > > > > > > > > > > > >From the above I take it that booting with a preloaded firmware is a > > > > > > > > > scenario that needs to be supported and not just a temporary stage. > > > > > > > > > > > > > > > > The current status of the Corstone-1000 SoC requires that there is > > > > > > > > a preloaded firmware for the external core. Preloading is done externally > > > > > > > > either through the FPGA bootloader or the emulator (FVP) before powering > > > > > > > > on the SoC. > > > > > > > > > > > > > > > > > > > > > > Ok > > > > > > > > > > > > > > > Corstone-1000 will be upgraded in a way that the A core running Linux is able > > > > > > > > to share memory with the remote core and also being able to access the remote > > > > > > > > core memory so Linux can copy the firmware to. This HW changes are still > > > > > > > > This is why this patchset is relying on a preloaded firmware. And it's the step 1 > > > > > > > > of adding remoteproc support for Corstone. > > > > > > > > > > > > > > > > > > > > > > Ok, so there is a HW problem where A core and M core can't see each other's > > > > > > > memory, preventing the A core from copying the firmware image to the proper > > > > > > > location. > > > > > > > > > > > > > > When the HW is fixed, will there be a need to support scenarios where the > > > > > > > firmware image has been preloaded into memory? > > > > > > > > > > > > No, this scenario won't apply when we get the HW upgrade. No need for an > > > > > > external entity anymore. The firmware(s) will all be files in the linux filesystem. > > > > > > > > > > > > > > > > Very well. I am willing to continue with this driver but it does so little that > > > > > I wonder if it wouldn't simply be better to move forward with upstreaming when > > > > > the HW is fixed. The choice is yours. > > > > > > > > > > > > > I think Robin has raised few points that need clarification. I think it was > > > > done as part of DT binding patch. I share those concerns and I wanted to > > > > reaching to the same concerns by starting the questions I asked on corstone > > > > device tree changes. > > > > > > > > > > I also agree with Robin's point of view. Proceeding with an initial > > > driver with minimal functionality doesn't preclude having complete > > > bindings. But that said and as I pointed out, it might be better to > > > wait for the HW to be fixed before moving forward. > > > > We checked with the HW teams. The missing features will be implemented but > > this will take time. > > > > The foundation driver as it is right now is still valuable for people wanting to > > know how to power control Corstone external systems in a future proof manner > > (even in the incomplete state). We prefer to address all the review comments > > made so it can be merged. This includes making the DT binding as complete as > > possible as you advised. Then, once the HW is ready, I'll implement the comms > > and the FW reload part. Is that OK please ? > > > > I'm in agreement with that plan as long as we agree the current > preloaded heuristic is temporary and is not a valid long term > scenario. Yes, that's the plan, no problem. Cheers, Abdellatif