From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E8DB6A8A6; Wed, 17 Apr 2024 07:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713337368; cv=none; b=dJRBN93gRUsZ3n9Nq/XcPiB4QxPq+/CC30ouEFoP4qEH6ZS3P0Qwaz72qI15TACnLMKjjbvg653/n+zp8ageTlxxip/pkMfSI52ni+qopte9hATELoHv+zEZ0pDkt000k2c7YssgSD8AEt/XwKFFgfJhee/AR6xdY5wcf8fOQrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713337368; c=relaxed/simple; bh=dLoPVcJwQ4v6YYynEYCpNfdJ0/RBBYsj8Trzjrt/SXI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YWTG+SdqX1wQUmkgi4B3c/5L38Nf7Ql+W65lb0sTwDY/o0WR1wmtikX5YNtaDE8Z8h9pbCOLniQ5pVKrPtn+jo/MAN143I99g3u8EPgGoSi0lPapn5C/6TacoybEFPbCtZCqmd7lhU/KF8MnSMWvqq9NbSQvGowxljXQ3gC3ClI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LmWoXw03; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LmWoXw03" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713337363; x=1744873363; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dLoPVcJwQ4v6YYynEYCpNfdJ0/RBBYsj8Trzjrt/SXI=; b=LmWoXw03FbF+/DzKWnkgrT5MKCM459lDuBTpyBWlmvXny73kzudpDosN 2hUXf7Pk7cKy2qfWSGB33CtMxORsoxvXpHRkquntZ7gs4Y3f0frsNDYdi jvr7Xd0cfU9DoABNFeJNeNZo+ik0J+xQxArhho1paHoSEJDhPOjJU5zGt LBE2UP0rxlfGj12Ag1KOeg/I7y/I+LEnC+AuWuZMAtahsej1DH25n3h35 /6oNtWugEOr926G9SU7IwWIgvV/iKL0TQTY+QfpcUFwILC9JYHEVyVqfo T1ITpMZjSgEsF/jU/zGa5iCG/zrTQW4DlFnD51WIHv7WJ7guZz5zn5Yh0 g==; X-CSE-ConnectionGUID: 4OqYt7/sSH6a5GVHyEGI3w== X-CSE-MsgGUID: gd4udFgiTo+SemP/XYZsJw== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="26275166" X-IronPort-AV: E=Sophos;i="6.07,208,1708416000"; d="scan'208";a="26275166" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 00:02:43 -0700 X-CSE-ConnectionGUID: z2WLZqFWQCayOm5eLJmklw== X-CSE-MsgGUID: 54JhpEPFRHGD4Jx/Ncy42g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,208,1708416000"; d="scan'208";a="27181095" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 00:02:41 -0700 Date: Wed, 17 Apr 2024 00:02:40 -0700 From: Isaku Yamahata To: Binbin Wu Cc: Isaku Yamahata , Chao Gao , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sean Christopherson , Sagi Shahar , Kai Huang , chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com, isaku.yamahata@linux.intel.com Subject: Re: [PATCH v19 105/130] KVM: TDX: handle KVM hypercall with TDG.VP.VMCALL Message-ID: <20240417070240.GF3039520@ls.amr.corp.intel.com> References: <20240404012726.GP2444378@ls.amr.corp.intel.com> <8d489a08-784b-410d-8714-3c0ffc8dfb39@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8d489a08-784b-410d-8714-3c0ffc8dfb39@linux.intel.com> On Wed, Apr 17, 2024 at 02:16:57PM +0800, Binbin Wu wrote: > > > On 4/4/2024 9:27 AM, Isaku Yamahata wrote: > > On Tue, Apr 02, 2024 at 04:52:46PM +0800, > > Chao Gao wrote: > > > > > > +static int tdx_emulate_vmcall(struct kvm_vcpu *vcpu) > > > > +{ > > > > + unsigned long nr, a0, a1, a2, a3, ret; > > > > + > > > do you need to emulate xen/hyper-v hypercalls here? > > > > No. kvm_emulate_hypercall() handles xen/hyper-v hypercalls, > > __kvm_emulate_hypercall() doesn't. > So for TDX, kvm doesn't support xen/hyper-v, right? > > Then, should KVM_CAP_XEN_HVM and KVM_CAP_HYPERV be filtered out for TDX? That's right. We should update kvm_vm_ioctl_check_extension() and kvm_vcpu_ioctl_enable_cap(). I didn't pay attention to them. -- Isaku Yamahata