From: Barry Song <21cnbao@gmail.com>
To: akpm@linux-foundation.org, joe@perches.com, linux-doc@vger.kernel.org
Cc: apw@canonical.com, broonie@kernel.org, chenhuacai@loongson.cn,
chris@zankel.net, corbet@lwn.net, dwaipayanray1@gmail.com,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
linux@roeck-us.net, lukas.bulwahn@gmail.com, mac.xxn@outlook.com,
sfr@canb.auug.org.au, v-songbaohua@oppo.com,
workflows@vger.kernel.org
Subject: [PATCH RESEND v6 0/2] codingstyle: avoid unused parameters for a function-like macro
Date: Mon, 6 May 2024 13:46:04 +1200 [thread overview]
Message-ID: <20240506014606.8638-1-21cnbao@gmail.com> (raw)
From: Barry Song <v-songbaohua@oppo.com>
-v6:
* collect ack of Joe, thanks!
* refine docs according to Jonathan, thanks!
* add checkpatch doc according to Joe, thanks!
-v5:
* Simplify the code for Patch 2 according to Joe's suggestions.
* add s-o-b of Barry according to Jeff Johnson
v5 link:
https://lore.kernel.org/all/20240401012120.6052-1-21cnbao@gmail.com/
-v4:
* fix Xining's email address, s/ma.xxn@outlook.com/mac.xxn@outlook.com/g
* fix some false positives of checkpatch.pl
* downgrade from ERROR to WARN in checkpatch.pl
Thanks for Joe's comments!
v4 link: https://lore.kernel.org/all/20240328022136.5789-1-21cnbao@gmail.com/
-v3:
https://lore.kernel.org/all/20240322084937.66018-1-21cnbao@gmail.com/
A function-like macro could result in build warnings such as
"unused variable." This patchset updates the guidance to
recommend always using a static inline function instead
and also provides checkpatch support for this new rule.
Barry Song (1):
Documentation: coding-style: ask function-like macros to evaluate
parameters
Xining Xu (1):
scripts: checkpatch: check unused parameters for function-like macro
Documentation/dev-tools/checkpatch.rst | 14 ++++++++++++++
Documentation/process/coding-style.rst | 23 +++++++++++++++++++++++
scripts/checkpatch.pl | 6 ++++++
3 files changed, 43 insertions(+)
--
2.34.1
next reply other threads:[~2024-05-06 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 1:46 Barry Song [this message]
2024-05-06 1:46 ` [PATCH RESEND v6 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters Barry Song
2024-05-06 1:46 ` [PATCH RESEND v6 2/2] scripts: checkpatch: check unused parameters for function-like macro Barry Song
2024-05-06 5:33 ` Joe Perches
2024-05-06 7:16 ` Barry Song
2024-05-06 16:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506014606.8638-1-21cnbao@gmail.com \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=broonie@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=chris@zankel.net \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukas.bulwahn@gmail.com \
--cc=mac.xxn@outlook.com \
--cc=sfr@canb.auug.org.au \
--cc=v-songbaohua@oppo.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).