From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org, jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH] x86/irq: use lapic_vector_set_in_irr to check for pending vectors in fixup_irqs.
Date: Mon, 6 May 2024 10:38:41 -0700 [thread overview]
Message-ID: <20240506103841.4d838866@jacob-builder> (raw)
In-Reply-To: <20240506111634.121460-1-imran.f.khan@oracle.com>
Hi Imran,
On Mon, 6 May 2024 21:16:34 +1000, Imran Khan <imran.f.khan@oracle.com>
wrote:
> No functional change, just using readily available helper which
> uses the same logic, that has been used here.
>
> Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
> ---
> arch/x86/kernel/irq.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 35fde0107901d..71432e42275c4 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -339,7 +339,7 @@
> DEFINE_IDTENTRY_SYSVEC_SIMPLE(sysvec_kvm_posted_intr_nested_ipi) /* A cpu
> has been removed from cpu_online_mask. Reset irq affinities. */ void
> fixup_irqs(void) {
> - unsigned int irr, vector;
> + unsigned int vector;
> struct irq_desc *desc;
> struct irq_data *data;
> struct irq_chip *chip;
> @@ -366,8 +366,7 @@ void fixup_irqs(void)
> if (IS_ERR_OR_NULL(__this_cpu_read(vector_irq[vector])))
> continue;
>
> - irr = apic_read(APIC_IRR + (vector / 32 * 0x10));
> - if (irr & (1 << (vector % 32))) {
> + if (lapic_vector_set_in_irr(vector)) {
> desc = __this_cpu_read(vector_irq[vector]);
>
> raw_spin_lock(&desc->lock);
I have a similar refactoring as part of the posted MSI series, but I
totally missed the existing helper lapic_vector_set_in_irr().
https://lore.kernel.org/lkml/171448372145.10875.6906928487300074547.tip-bot2@tip-bot2/
Let me send out a fix patch against tip tree.
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -505,13 +505,7 @@ static inline bool lapic_vector_set_in_irr(unsigned int vector)
static inline bool is_vector_pending(unsigned int vector)
{
- unsigned int irr;
-
- irr = apic_read(APIC_IRR + (vector / 32 * 0x10));
- if (irr & (1 << (vector % 32)))
- return true;
-
- return pi_pending_this_cpu(vector);
+ return lapic_vector_set_in_irr(vector) || pi_pending_this_cpu(vector);
}
Thanks,
Jacob
prev parent reply other threads:[~2024-05-06 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 11:16 [PATCH] x86/irq: use lapic_vector_set_in_irr to check for pending vectors in fixup_irqs Imran Khan
2024-05-06 17:38 ` Jacob Pan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506103841.4d838866@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=imran.f.khan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).