From: "David E. Box" <david.e.box@linux.intel.com>
To: linux-doc@vger.kernel.org, david.e.box@linux.intel.com,
ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: [PATCH V2 2/3] tools/arch/x86/intel_sdsi: Rework Makefile
Date: Tue, 7 May 2024 11:01:05 -0700 [thread overview]
Message-ID: <20240507180106.5218-2-david.e.box@linux.intel.com> (raw)
In-Reply-To: <20240507180106.5218-1-david.e.box@linux.intel.com>
In preparation for more source files, rework the Makefile to handle
prerequisites more generically, making it easier to isolate future changes.
Also update PHONY targets.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
V2 - New Patch.
tools/arch/x86/intel_sdsi/Makefile | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/tools/arch/x86/intel_sdsi/Makefile b/tools/arch/x86/intel_sdsi/Makefile
index 5de2288cda79..47b6fd98372c 100644
--- a/tools/arch/x86/intel_sdsi/Makefile
+++ b/tools/arch/x86/intel_sdsi/Makefile
@@ -1,21 +1,25 @@
# SPDX-License-Identifier: GPL-2.0
# Makefile for Intel Software Defined Silicon provisioning tool
-
-intel_sdsi: intel_sdsi.c
-
-CFLAGS = -Wextra
-
+include ../../../scripts/Makefile.include
BINDIR ?= /usr/sbin
-override CFLAGS += -O2 -Wall
+SRCS = intel_sdsi.c
-%: %.c
- $(CC) $(CFLAGS) -o $@ $< $(LDFLAGS)
+OBJS = $(SRCS:.c=.o)
+
+override CFLAGS += -O2 -Wall -Wextra
+
+intel_sdsi: $(OBJS)
+ $(CC) $(CFLAGS) $(OBJS) -o $@
+
+%.o: %.c
+ $(CC) $(CFLAGS) -c $< -o $@
-.PHONY : clean
clean :
- @rm -f intel_sdsi
+ @rm -f intel_sdsi $(OBJS)
install : intel_sdsi
install -d $(DESTDIR)$(BINDIR)
install -m 755 -p intel_sdsi $(DESTDIR)$(BINDIR)/intel_sdsi
+
+.PHONY : clean install
--
2.34.1
next prev parent reply other threads:[~2024-05-07 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 18:01 [PATCH V2 1/3] platform/x86/intel/sdsi: Add ioctl SPDM transport David E. Box
2024-05-07 18:01 ` David E. Box [this message]
2024-05-07 18:01 ` [PATCH V2 3/3] tools/arch/x86/intel_sdsi: Add attestation support David E. Box
2024-05-08 8:23 ` [PATCH V2 1/3] platform/x86/intel/sdsi: Add ioctl SPDM transport Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507180106.5218-2-david.e.box@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).