linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Christoph Hellwig <hch@lst.de>,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the dma-mapping tree
Date: Wed, 8 May 2024 08:51:02 +0200	[thread overview]
Message-ID: <20240508065102.GC10736@lst.de> (raw)
In-Reply-To: <20240508091631.1ec34a25@canb.auug.org.au>

On Wed, May 08, 2024 at 09:16:31AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dma-mapping tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Thanks.  I'll fold in the patch below to drop two consts for now.
Alexander, if you want to pass the consts through we'll also need to
modify page_pool_get_dma_addr, which looks doable.  If you want that,
please send an incremental patch.

diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index 8836aaaf23855f..4f9d1bd7f4d187 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -399,7 +399,7 @@ static struct page *__page_pool_get_cached(struct page_pool *pool)
 }
 
 static void __page_pool_dma_sync_for_device(const struct page_pool *pool,
-					    const struct page *page,
+					    struct page *page,
 					    u32 dma_sync_size)
 {
 #if defined(CONFIG_HAS_DMA) && defined(CONFIG_DMA_NEED_SYNC)
@@ -413,7 +413,7 @@ static void __page_pool_dma_sync_for_device(const struct page_pool *pool,
 
 static __always_inline void
 page_pool_dma_sync_for_device(const struct page_pool *pool,
-			      const struct page *page,
+			      struct page *page,
 			      u32 dma_sync_size)
 {
 	if (pool->dma_sync && dma_dev_need_sync(pool->p.dev))

  reply	other threads:[~2024-05-08  6:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07 23:16 linux-next: build failure after merge of the dma-mapping tree Stephen Rothwell
2024-05-08  6:51 ` Christoph Hellwig [this message]
2024-05-08  8:51   ` Alexander Lobakin
2024-05-08 13:45     ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2020-11-27  6:58 Stephen Rothwell
2020-11-27  9:21 ` Christoph Hellwig
2020-11-27  9:59   ` Stephen Rothwell
2020-11-27  9:33 ` Christoph Hellwig
2012-02-13  5:40 Stephen Rothwell
2012-02-13  7:31 ` Kyungmin Park
2012-02-13 15:05 ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240508065102.GC10736@lst.de \
    --to=hch@lst.de \
    --cc=aleksander.lobakin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).