From: Dmitry Osipenko <digetx@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Lubomir Rintel <lkundrak@v3.sk>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] dt-bindings: mfd: Add ENE KB930 Embedded Controller binding
Date: Fri, 9 Oct 2020 23:06:11 +0300 [thread overview]
Message-ID: <2027587e-084d-8125-9830-6ff07bbe7f2d@gmail.com> (raw)
In-Reply-To: <20201008230032.a2mgd3yymxbbreqo@earth.universe>
09.10.2020 02:00, Sebastian Reichel пишет:
> Hi,
>
> On Sun, Sep 06, 2020 at 10:50:59PM +0300, Dmitry Osipenko wrote:
>> Add binding document for the ENE KB930 Embedded Controller.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> .../devicetree/bindings/mfd/ene-kb930.yaml | 66 +++++++++++++++++++
>> 1 file changed, 66 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb930.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
>> new file mode 100644
>> index 000000000000..635c8966ca22
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/ene-kb930.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ENE KB930 Embedded Controller bindings
>> +
>> +description: |
>> + This binding describes the ENE KB930 Embedded Controller attached to an
>> + I2C bus.
>> +
>> +maintainers:
>> + - Dmitry Osipenko <digetx@gmail.com>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - acer,a500-iconia-ec # Acer A500 Iconia tablet device
>> + - enum:
>> + - ene,kb930
>> + reg:
>> + maxItems: 1
>> +
>> + monitored-battery: true
>
> ^^^ this is not being used by your battery driver. Do you plan
> to use it in the future or is it a copy&paste mistake? :)
Hello, this is correct that driver doesn't use monitored-battery info,
but I was thinking that it's good to have anyways in the device-tree
because this completes hardware description + the gauge driver isn't
aware about maximal battery temperature. Hence it may become useful and
it doesn't hurt to have that additional information about battery cell.
next prev parent reply other threads:[~2020-10-09 20:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 19:50 [PATCH v3 0/5] Introduce Embedded Controller driver for Acer A500 Dmitry Osipenko
2020-09-06 19:50 ` [PATCH v3 1/5] dt-bindings: mfd: Add ENE KB930 Embedded Controller binding Dmitry Osipenko
2020-09-08 19:46 ` Rob Herring
2020-10-08 23:00 ` Sebastian Reichel
2020-10-09 20:06 ` Dmitry Osipenko [this message]
2020-09-06 19:51 ` [PATCH v3 2/5] mfd: Add driver for Embedded Controller found on Acer Iconia Tab A500 Dmitry Osipenko
2020-09-06 19:51 ` [PATCH v3 3/5] power: supply: Add battery gauge driver for " Dmitry Osipenko
2020-10-08 22:57 ` Sebastian Reichel
2020-09-06 19:51 ` [PATCH v3 4/5] leds: Add " Dmitry Osipenko
2020-09-24 12:00 ` Pavel Machek
2020-09-25 15:02 ` Dmitry Osipenko
2020-09-06 19:51 ` [PATCH v3 5/5] ARM: tegra: acer-a500: Add Embedded Controller Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2027587e-084d-8125-9830-6ff07bbe7f2d@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jonathanh@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).