From: Xianting Tian <xianting.tian@linux.alibaba.com>
To: Jiri Slaby <jirislaby@kernel.org>,
gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de,
osandov@fb.com
Cc: linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] tty: hvc: pass DMA capable memory to put_chars()
Date: Thu, 5 Aug 2021 19:14:13 +0800 [thread overview]
Message-ID: <202cf491-5cdd-999f-d556-a5ebd2b4e266@linux.alibaba.com> (raw)
In-Reply-To: <f1b92c7d-0eaf-4eac-ecd2-fbb74fb63b52@kernel.org>
在 2021/8/5 下午4:09, Jiri Slaby 写道:
> On 05. 08. 21, 9:58, Jiri Slaby wrote:
>> Hi,
>>
>> On 04. 08. 21, 4:54, Xianting Tian wrote:
>>> @@ -933,6 +949,16 @@ struct hvc_struct *hvc_alloc(uint32_t vtermno,
>>> int data,
>>> hp->outbuf_size = outbuf_size;
>>> hp->outbuf = &((char *)hp)[ALIGN(sizeof(*hp), sizeof(long))];
>
> This deserves cleanup too. Why is "outbuf" not "char outbuf[0]
> __ALIGNED__" at the end of the structure? The allocation would be
> easier (using struct_size()) and this line would be gone completely.
I will make the cleanup in v4.
>
>>> + /*
>>> + * hvc_con_outbuf is guaranteed to be aligned at least to the
>>> + * size(N_OUTBUF) by kmalloc().
>>> + */
>>> + hp->hvc_con_outbuf = kzalloc(N_OUTBUF, GFP_KERNEL);
>>> + if (!hp->hvc_con_outbuf)
>>> + return ERR_PTR(-ENOMEM);
>>
>> This leaks hp, right?
>
> Actually, why don't you make
> char c[N_OUTBUF] __ALIGNED__;
>
> part of struct hvc_struct directly?
thanks, it a good idea, I will change it in v4.
>
>> BTW your 2 patches are still not threaded, that is hard to follow.
>>
>>> +
>>> + spin_lock_init(&hp->hvc_con_lock);
>>> +
>>> tty_port_init(&hp->port);
>>> hp->port.ops = &hvc_port_ops;
>>
>> thanks,
next prev parent reply other threads:[~2021-08-05 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 2:54 [PATCH v3 1/2] tty: hvc: pass DMA capable memory to put_chars() Xianting Tian
2021-08-05 7:58 ` Jiri Slaby
2021-08-05 8:09 ` Jiri Slaby
2021-08-05 11:14 ` Xianting Tian [this message]
[not found] ` <40f78d10-0a57-4620-e7e2-f806bd61abca@linux.alibaba.com>
2021-08-05 8:18 ` Greg KH
2021-08-05 8:23 ` Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202cf491-5cdd-999f-d556-a5ebd2b4e266@linux.alibaba.com \
--to=xianting.tian@linux.alibaba.com \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=osandov@fb.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).