linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] time: Change log level of "NOHZ: local_softirq_pending" message
       [not found] <350315726.726339.1360327201303.JavaMail.root@redhat.com>
@ 2013-02-08 17:37 ` Rado Vrbovsky
  2013-03-25  9:58   ` [tip:timers/core] tick: Change log level of NOHZ: local_softirq_pending message tip-bot for Rado Vrbovsky
  0 siblings, 1 reply; 2+ messages in thread
From: Rado Vrbovsky @ 2013-02-08 17:37 UTC (permalink / raw)
  To: linux-kernel, Thomas Gleixner; +Cc: Don Zickus

The "NOHZ: local_softirq_pending" message is a largely informational message.
This makes extra work for customers that have a policy of investigating all
kernel log messages logged at <= KERN_ERR log level.
This patch sets the message to a different log level.

Signed-off-by: Rado Vrbovsky <rvrbovsk@redhat.com>

---
 kernel/time/tick-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index d58e552..ece2beb 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -481,7 +481,7 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
 
                if (ratelimit < 10 &&
                    (local_softirq_pending() & SOFTIRQ_STOP_IDLE_MASK)) {
-                       printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
+                       printk(KERN_WARNING "NOHZ: local_softirq_pending %02x\n",
                               (unsigned int) local_softirq_pending());
                        ratelimit++;
                }
-- 
1.7.11.7

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:timers/core] tick: Change log level of NOHZ: local_softirq_pending message
  2013-02-08 17:37 ` [PATCH] time: Change log level of "NOHZ: local_softirq_pending" message Rado Vrbovsky
@ 2013-03-25  9:58   ` tip-bot for Rado Vrbovsky
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Rado Vrbovsky @ 2013-03-25  9:58 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, rvrbovsk, tglx, dzickus

Commit-ID:  cfea7d7e452f57682a0bb55a55e9f79c569558c2
Gitweb:     http://git.kernel.org/tip/cfea7d7e452f57682a0bb55a55e9f79c569558c2
Author:     Rado Vrbovsky <rvrbovsk@redhat.com>
AuthorDate: Fri, 8 Feb 2013 12:37:30 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 25 Mar 2013 10:46:59 +0100

tick: Change log level of NOHZ: local_softirq_pending message

The "NOHZ: local_softirq_pending" message is a largely informational
message.  This makes extra work for customers that have a policy of
investigating all kernel log messages logged at <= KERN_ERR log level.
This patch sets the message to a different log level.

[ tglx: Use pr_warn() ]

Signed-off-by: Rado Vrbovsky <rvrbovsk@redhat.com>
Cc: Don Zickus <dzickus@redhat.com>
Link: http://lkml.kernel.org/r/2037057938.893524.1360345050772.JavaMail.root@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/time/tick-sched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index a19a399..225f8bf 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -482,8 +482,8 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
 
 		if (ratelimit < 10 &&
 		    (local_softirq_pending() & SOFTIRQ_STOP_IDLE_MASK)) {
-			printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
-			       (unsigned int) local_softirq_pending());
+			pr_warn("NOHZ: local_softirq_pending %02x\n",
+				(unsigned int) local_softirq_pending());
 			ratelimit++;
 		}
 		return false;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-25 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <350315726.726339.1360327201303.JavaMail.root@redhat.com>
2013-02-08 17:37 ` [PATCH] time: Change log level of "NOHZ: local_softirq_pending" message Rado Vrbovsky
2013-03-25  9:58   ` [tip:timers/core] tick: Change log level of NOHZ: local_softirq_pending message tip-bot for Rado Vrbovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).