From: Heiko Stuebner <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Caesar Wang <wxt@rock-chips.com>,
Doug Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Stephen Barber <smbarber@chromium.org>,
linux-arm-kernel@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer
Date: Wed, 22 Mar 2017 09:26:41 +0100 [thread overview]
Message-ID: <20415662.PctC9IM4SC@phil> (raw)
In-Reply-To: <20170320235344.126298-5-briannorris@chromium.org>
Am Montag, 20. März 2017, 16:53:44 CET schrieb Brian Norris:
> We need to enable this regulator before the digitizer can be used. Wacom
> recommended waiting for 100 ms before talking to the HID.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> v3:
> * reintroduced into patch set; bindings are in linux-next
> ---
> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts index
> 2f720cf2fd07..f4714c4606f3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> @@ -232,6 +232,9 @@ ap_i2c_dig: &i2c2 {
according to the hid-over-i2c binding, this should use a special compatible
like
compatible = "wacom,w9013", "hid-over-i2c"
As the binding patch is from Caesar, I assume that is the Kevin component and
I can add that myself, just need confirmation that this is actually the correct
component :-) .
Thanks
Heiko
> pinctrl-names = "default";
> pinctrl-0 = <&cpu1_dig_irq_l &cpu1_dig_pdct_l>;
>
> + vdd-supply = <&p3_3v_dig>;
> + post-power-on-delay-ms = <100>;
> +
> interrupt-parent = <&gpio2>;
> interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
next prev parent reply other threads:[~2017-03-22 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 23:53 [PATCH v3 0/4] arm64: dts: rockchip: support Google Kevin Brian Norris
2017-03-20 23:53 ` [PATCH v3 1/4] dt-bindings: Document rk3399 Gru/Kevin Brian Norris
2017-03-22 9:01 ` Heiko Stuebner
2017-03-22 17:56 ` Brian Norris
2017-03-20 23:53 ` [PATCH v3 2/4] arm64: dts: rockchip: add Gru/Kevin DTS Brian Norris
2017-03-21 11:02 ` Enric Balletbo Serra
2017-03-22 11:59 ` Heiko Stuebner
2017-03-22 17:57 ` Brian Norris
2017-03-20 23:53 ` [PATCH v3 3/4] arm64: dts: rockchip: describe Gru/Kevin OPPs + CPU regulators Brian Norris
2017-03-21 11:04 ` Enric Balletbo Serra
2017-03-22 12:00 ` Heiko Stuebner
2017-03-20 23:53 ` [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer Brian Norris
2017-03-22 8:26 ` Heiko Stuebner [this message]
2017-03-22 18:14 ` Brian Norris
2017-03-22 23:57 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20415662.PctC9IM4SC@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=smbarber@chromium.org \
--cc=wxt@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).