From: Joe Perches <joe@perches.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: ab8500-debugfs: Remove extraneous curly brace
Date: Fri, 25 Dec 2020 23:03:27 -0800 [thread overview]
Message-ID: <204aeca57b8649b311745c8f9c56f48dfcf36a85.camel@perches.com> (raw)
In-Reply-To: <20201226013549.1973451-1-natechancellor@gmail.com>
On Fri, 2020-12-25 at 18:35 -0700, Nathan Chancellor wrote:
> Clang errors:
>
> ../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does
> not return a value [-Werror,-Wreturn-type]
> }
> ^
> ../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '('
> return 0;
> ^
> ../drivers/mfd/ab8500-debugfs.c:1529:1: error: extraneous closing brace ('}')
> }
> ^
> 3 errors generated.
>
> The cleanup in ab8500_interrupts_show left a curly brace around, remove
> it to fix the error.
>
> Fixes: 886c8121659d ("mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/mfd/ab8500-debugfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
[]
> @@ -1521,7 +1521,6 @@ static int ab8500_interrupts_show(struct seq_file *s, void *p)
> line + irq_first,
> num_interrupts[line],
> num_wake_interrupts[line]);
> - }
> seq_putc(s, '\n');
It looks as if this seq_putc should be removed as well
as the seq_printf above already ends in a newline.
> }
>
>
>
> base-commit: 61d791365b72a89062fbbea69aa61479476da946
prev parent reply other threads:[~2020-12-26 7:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 1:35 [PATCH] mfd: ab8500-debugfs: Remove extraneous curly brace Nathan Chancellor
2020-12-26 7:03 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204aeca57b8649b311745c8f9c56f48dfcf36a85.camel@perches.com \
--to=joe@perches.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).