From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754437AbcH2P7f (ORCPT ); Mon, 29 Aug 2016 11:59:35 -0400 Received: from mail-bl2nam02on0043.outbound.protection.outlook.com ([104.47.38.43]:23424 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753937AbcH2P7U (ORCPT ); Mon, 29 Aug 2016 11:59:20 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: 0ac94369-ef8199800001694f-ad-57c459b30087 Subject: Re: [PATCH] scsi: move function declarationes to scsi_priv.h To: Baoyou Xie , , References: <1472317197-7865-1-git-send-email-baoyou.xie@linaro.org> CC: , , , From: Bart Van Assche Message-ID: <204f29e4-f582-5961-b62c-b0bf9de67b86@sandisk.com> Date: Mon, 29 Aug 2016 08:58:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1472317197-7865-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsXCddJ5ke6WyCPhBmsnClkcfXWCxeLZ5+OM Fqsm5llc3jWHzaL7+g42i+XH/zFZrHw3n92B3ePOtT1sHg8ObWbx+Pj0FovH501yHmv2/WAJ YI3isklJzcksSy3St0vgyph//QtjwWHWita1DSwNjLdYuhg5OSQETCR2TbjK3MXIxSEksJRJ 4vrJxawQzg5GiftrWxlhqua3rWGBqmKUuHTyDjtIQljAVeLnhjesILaIQKJEw5UXQHEOoCIX iWnv00HCzAJ5Evfnb2IGsdkEjCS+vZ8JtplXwE5iw+oZYHEWAVWJbQ9vgY0UFQiTmHb3LTtE jaDEyZlPwOo5gVZ9eHiSEWQ8s4C9xIOtZRDj5SW2v50D9oCEwFFWiV2/JoP1CgmoS5xcMp9p AqPwLCSjZiG0z0LSvoCReRWjWG5mTnFuemqBoalecWJeSmZxtl5yfu4mRki0ZO5gvPvE+xCj AAejEg+vhdORcCHWxLLiytxDjBIczEoivCv8gUK8KYmVValF+fFFpTmpxYcYpTlYlMR53e59 CRMSSE8sSc1OTS1ILYLJMnFwSjUwmoSse8NdqeNWHt63eK+xysv+ny5P26d803qs2Zf8L9A7 QZxXRmTegS8spT63gvfNWRG1O8vDOLz7l13vnnXdX2RNu97nBB7eU3bsRb1dK//ayufNfHNj 3P3E2+zKziTKC+1idKip+pbir9N1YuP2/JQv0X/f7dq45ozUsU6vl7zLL9tIM8xVYinOSDTU Yi4qTgQAtWjE+ZICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGJMWRmVeSWpSXmKPExsXCtZEjRfdQ9JFwg7crxSyOvjrBYvHs83FG i1UT8ywu75rDZtF9fQebxfLj/5gsVr6bz+7A7nHn2h42jweHNrN4fHx6i8Xj8yY5jzX7frAE sEZx2aSk5mSWpRbp2yVwZcy//oWx4DBrRevaBpYGxlssXYycHBICJhLz29YA2VwcQgKLGSX+ 9u9iA0kIC7hK/NzwhhXEFhGIlbjX2MvYxcgBVOQiMe19OkiYWSBN4tv6e0wgNpuAkcS39zPB ZvIK2ElsWD2DGcRmEVCV2PbwFjuILSoQJjHt7lt2iBpBiZMzn4DVcwKt+vDwJCPETFuJO3N3 M0PY8hLb385hnsDINwtJyywkZbOQlC1gZF7FKJabmVOcm55ZYGikV5yYl5JZnK2XnJ+7iREc spxROxivTzQ/xMjEwSnVwFgxUZn39i7x7RpJnOyvij4bX+ZLFo7LuBOUzXEos9858WsCm/42 j6sxCm/eZDLudWNT+flhbdvWDRpty4Rbjs9+Fvta/tI005dNFZs/xZ2fcD/+hwaH0udfbT97 dIXni8zcfqzmfe3lrfeFurjtfVc7rGqolOq6/t6XLeXcNqsN/Gyi0kvSlJVYijMSDbWYi4oT ASVq870JAgAA X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(24454002)(199003)(377454003)(189002)(626004)(68736007)(50466002)(65956001)(87936001)(586003)(7696003)(65806001)(47776003)(7846002)(5001770100001)(64126003)(97736004)(31686004)(4001350100001)(189998001)(8936002)(356003)(36756003)(106466001)(2201001)(76176999)(53416004)(92566002)(77096005)(33646002)(50986999)(54356999)(23746002)(31696002)(305945005)(2950100001)(2270400002)(86362001)(5660300001)(81156014)(2906002)(230700001)(69596002)(81166006)(19580395003)(8676002)(4326007)(19580405001)(83506001)(11100500001)(65826007);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR02MB1305;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD004;1:zEoQcHBGvWyeJM6Kx2mdwPwoONaSgGNE1ru7CYC7Nesde/uxfL4cA4c5bLt46oq3yg2vLYz49j2udYVCkSJ80hLta8SI54rrI41nYiDsL5Q7qhnZtXZ0TdFhmtlokPPYDbvr9uQH6hJ1vWhntfJrKiurO5eTBj1b4QreZAfyf3VdzQa8rBfJXBh7mYgEQ7u1jaVvpLjA+jW6G84AhS5pvWU9r9ZjiLQHNMo7OU7sjq2linflHy0ykTPgIzskeuHg3vMmnKBX96YK/7f+VicnCmcz3SLwoOWc9XAJzvvmYnSPNxfizeuUQe+gTf2n8uUF+MKlWQngb6i6iQLHSjTSoPVX24cmB29hkBudc1DNDUbF7opIQIE1+MdRS/z0jhj5wZtoAPBcIaR9PZXo410+e1deOZT2pEu3nJCTpYf5MNQooHB8+OgK7G1zC7QsfJUzruDhucosQRJS9RAxICepqMwcuGGfBHjMCZ8imfJwGok= X-MS-Office365-Filtering-Correlation-Id: fe2dbdcc-d42a-47d0-ad6b-08d3d02565df X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1305;2:SYBztbsGFDRe8ZVSNNMIprbUKbMraDelvB4icaMzjY2mT00i/yIcd6ApAuAgy2dHIsN+Lp/PjwUNGaV5yt1WgDhNvKuYIHN2m0qUPU5TbWSiOpK4R0ZK/cWFGppYBQ6KQ+xHGQs3xSs14npRsWRxwyJUMLKqsbhbWIHOgC9mF2LButP/Zeznjh7KtoOiZ8o6;3:FSXfJbHqsdQiSiEyRiPoviRePWSFQ6nEWzO5GuVamHqAeY+z8Y5kWwhZvpzEb6atcm75sWr71Y3Aacsn6L4Ahc/A7V2R7OlN9SxgyJp0Z7fJwXXYl8mYTnx0OG5EoY+EMIdbXSt+jX4kTknStQRcDme9FtuRwWrJZhv/gO3RSGA1hLfKbj1ecBrHvJxOyZq1LOcD4//3eiXpBUSaSJt05hX/1PgGFixF5KiWtPy8svgAJKH2gSmspWfUCYFAdMODN7BU0gofHNraWOesJSz25g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:DM2PR02MB1305; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1305;25:r85gC317JiUkvpyFM+BNawhAP6ud86LlYt6vNX+ung8wgtUEMidC2ye3+eYjJQfPetzYmPubg0xRzJ3MqscIllNAMcLJ76rcGE54YLUJRRXehiW0ESshNSRMg5EdiNkvRh1aKPPEjMh3cVxIYpOjUqhCzUm5zITqG8TCiKePEjQFP+D0Iqe3vtLf6KKh94QCmJYYkL0WvXONyrLHxbK4VnGinoaPC63fJ2Uxe1lLQJf7sotc+pTeOmxyPKdjVM3X3N/dN3Gr7xiu81mlGBrJarEYJ8UPYsTzTsZwuPrjCK1RlE1TVrj734ZqmDAfW+uvEoQOZ69ssWSqOsIJ67oQCq3FehKOvsQ2gzW1TFqW20N2DT/AIQ9EN6vGrLDWlQZjn8+VOwLzvZZTVHKzuogwsS1aZHZjXotJh1p1w1xzpL5nOgBvD1R1/GZh+9nLSMzkKdV1+vrMugQvNLWiehNLDvCribU/eBtrdcFuWsiZwDsZ3iXSQ42j36HMMTNALchCRBIr7z4e/fizQ6mUJbrDLbe2uNyTPbgrzSTkZDDNH5/HgR3XyUXjsjjso+DKKiTNS2WZRuZ/5RfjGFitMEgoOUANXZf5VUc3UQ/QdNZ1zOvqkZlW64uUkuRIX+ASmHzzN6w/M3x/6ayq1Qnkf+SWvNNlVivVQpO2fxRa1avaxomxIj/1pSeyH90JDHIP+QFWGJYQOshaxK5D0We+7g+2nHK29Juc04hVjJfwEC95E+GlQqV1OpgQfPK2bqnmNQVai5O38FW+PFOBsMQmWCHJx/cXrHA8Y/Edf9NV3Ti9brA= X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1305;31:glTituch6i/6u2mDXhHmDwtYsfwCYRUDh+10z4znE202HhdoFDHHQ7R6n1qGKn1MSnkvvcT9+SFFA2ERgKzjnXUZXlmFEciuUW9TeaxDC6z+gP9s6wqzAxoO7+UF7Pqpn31AwNF5HhZ7qrl6Tt1AdfrmkTIAIWZE1MWmlzz476W0quGkw/e2r5j76tF0j7jjo1Ebxf2hCTe9Kr+zh6z46V/I68pwSLdHJxUb84oKMHw=;20:bQU3nWXQfqaFOgMBOPmRFjfBYreCtwb6EIixHvpUXOLYAJLVOXsCZYExix0Pp+OPXQizoGyfBUSx7516l+HKkkQWOczM/XZvMrFUOz02yBIAG9723MOak4aarNuxAQv7tTAiC6ngar9m9eHuMru1Yufu638lu1WaQMDTmMpHlVTZzxd/qSVJjA+YXTdkfkEHzFpuFvwdFv2Oen5ldGi8xvnn72RjakibKHEYcuHQiAYnP3s4dIMF85pCxuEKYGxHoeVeZeIz65/pWgw27J6Vai7eKPw0eWWiGCA3CPwQZBPpSltxcXVgdQJSvr+PxxzaVwlTYzeckA2mbBirZRwpQDcD9CfjwHTZ3hUD8h2Ax8o86BguXPnokMI3/PpJ3ZD9p+WxAnD7ineu0sN+p5Cg3cz2mJ+iQZ3w8jDHx5wO60y/qJ3krxLjSSapwwBpRNZwD2Dbr+wOWBcN8E+Lujn6TsLMtnrJnGQ4LcjgWS1a7a002lg5sIQ6Joumzmqkz56W X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13016025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:DM2PR02MB1305;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB1305; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1305;4:7DhBoYd8aobU9C4hk8bWIO72eRJK7BTUy50HlH429igVhspsvWn/N5JP471s02VlwcsBNn3NIYIijuubomso0jufBsckVigDWV/m4OQhDBcNssrxKOxMyaEA+OEsTel/YTEW8imcnoU4Vy4Vp+r/qEa9MDYJ6l3iAcI9SMQRWCPcoZuiv3Hdup3uQOd9Nt6KEhYM4iS9sfJjwtHdrGUfipIVh7e15Lt/3lWDMyjTo2NKYht6luvuC46xkVRlVuoowDzV+MIEq6PlYXwHeljMQrrCMPN006bi9/INXJixaCrTad60Nc+r1H3Wq4IX1pF1WJ2Ofx7E0QPeK3BwSnSbGzQXpsOAMUJtIy1Xq8vPOnGS5aY8erREQMouIrReAOeUYpyyCY6TR3f3uxui4+ulldj7mlFnzHxppWI5ZNWxX301isy+yuvarxD490mcNw4ZsAOPZV24UfPuSZZcLCnEwqfQx5B4rwrOcxS3VO0xCyA= X-Forefront-PRVS: 0049B3F387 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM2PR02MB1305;23:zIxAyj1bdnggTjJG8Ap6ZxuKsEYJQ2YQAKAR+?= =?Windows-1252?Q?AUxA/nA0zt/T8gAF25TFY2z0Z/UfQqa8srTKScxQK3V/ZZFj/2fWrhio?= =?Windows-1252?Q?XJhnbqoPiGUOEpCgyf2h7s2sxFS2SG2PUPYC0IculeLtRV9R7nhKqzjl?= =?Windows-1252?Q?qP6wUTvQDNZZKEmY9onjpl1ebG3jhQD+/zJm6XoYgvYDocGcb4eI857E?= =?Windows-1252?Q?VfsD7RYthdii+JFTwfkt+rQphMJ6rXu2Sr48/3LpqhsPpUlLNNwub7JE?= =?Windows-1252?Q?5EloSCLrtrm4U45r7UVmUUQuVV+IEjTS85Y9G7db59Iv7CKXHJ73CYq6?= =?Windows-1252?Q?3raGw8Zl41WNlkDQR+HSZsM1l+B7Q0hSxNsL++rcyjcgEqlo9sOklKUz?= =?Windows-1252?Q?2Snb4M2pQGYNZim9gQKBeiHX1A8n+14OeLbKsii2jpHn56mKfjRG3vmx?= =?Windows-1252?Q?MYBUi8dVKfOKtAEbXovSGGjIG0ktuHXfDZToqlsYQMt84QC9wBGwxkst?= =?Windows-1252?Q?EevL0wFKtcb2AyNDpxwG1WvIPpRTEhzxCWr3S/+D9ja+wU4afaCKWi/H?= =?Windows-1252?Q?KyJNeVK+ZXIMEVEY4S5yBEnspDxBzWlNMJcRNo9zqN1XT3SOj4PffvkF?= =?Windows-1252?Q?lROqHRCLD67spu17Zx28uuhBRYIr0aXhl60JzNbDQqGb6OF2fkvCAXNc?= =?Windows-1252?Q?F9XuJV57yinf/m0Fz4fwxcIq3qNhFT1lvLpkfh+JLnGpnnEEjkuMfUb8?= =?Windows-1252?Q?dpgiZ38LeqS79sdAdqnQMrqfI5m/687TMa8zJw5FGxllcqB/sLYaST+k?= =?Windows-1252?Q?C1qElg4bjTOJVlf42/y52BZa+cXFp9KtstLCxUGm03WDVPHmdXkceQln?= =?Windows-1252?Q?/W+Pwmhkda1LFe/sci2LSELKWVMegopjK6lUrd6MrzAIPx0M6puWZsqS?= =?Windows-1252?Q?JpGtomqJtTSDXUMobQJlB2BrgphrDBoLHVWz3SJX2rmXnePJXoMtHSyp?= =?Windows-1252?Q?pWPNeXjVoNwjWpkgwND55wadkxoiGjfWmP4q21oLVhTjKOl/KDrTly3U?= =?Windows-1252?Q?MN6rGK9UoDeRovxarKQV+ZyJbjV7sVm6r1wCUBBewvt8DC2nk+SistxP?= =?Windows-1252?Q?aN5U3goz8eNt7FDuRDCloBFxlYRh3yYxO54rFljBok6QSZ8fpZMRbPUK?= =?Windows-1252?Q?MVf5PwmRe5VQRvM03I6Eiqc3x8jFfCsERQfZx7jXX2XjpfZ4DYXagjpc?= =?Windows-1252?Q?6iKzZteksT7w1cyxNo/pJgfo4ENDgxM2UvbGc86T2KYRfboaJJKZdBfS?= =?Windows-1252?Q?kqnoUHNZlb7BO04nUzQfMWL4WgKwKNffke9Ahy6IhOnLI2veTh4hw0AO?= =?Windows-1252?Q?m6lWzqvX55gSzFDS6Im1rc0xUlAqQMJumWyGmvXi8LtudS2bgOIzW8?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1305;6:2xOPFCVdzz22+gKEe4AM3QaE24MJ8sAusJq9Hz0bal6Tde3CkMW11QOVJm+XFq5JCooN+OpEbufYWk3LO+tRh42Pr1g/VtSCYVe0XhPTJSRyBDbADvCuY6k2KjghIvgfhahweht6/4tPHVVn3c/FVSt45zgM3HPPygCMduD1FySo+0KowkjGuVxcc5haleTwdwRvOgiHod9Bjuzos4vutMuRB6I7YYdjRwmzUg+I6XH3GE+joBuMqYAhEYJ4jySCwW8TjPm9fgfkAsF73FMVGebk7T2RSR9wsqUveIzafkER2tPpPvnzReVN3fa8Ku6cQw92E0IrLHx44ZaPNoVaXA==;5:A1MdSgnP3XddTZ0p1RbK2uoF7Eb1BRz1snxPcGMqJDSYTNghTl2YUuxTkSXJn63fdiZ/eKvGOiQayl1sg2aA2UeJ98kBqCv3v+O85CA5mfSz5VTCDDvAv/pVuK/70SRuVrknfffYoQVoJyk/8bUN6A==;24:rRsLqXBsr+u1D98NFvkkPpFQDPalzh/XSbUvfeezPLOq+KSgg9cgiynjF4OLsbG1dWJcw7OboVXzfopP9g742BIzrxAwLSnbYfe/WUQTlew=;7:tnRaKipQwaVS4Yf0QGS30KGQ9rAYB9sRFZGpOh2NAmSU9KLVkSXixtu4dDZMNIGbViCogTuO3nyLu0CT2eGb8dJq0uvU3C/EVnh7K6SUW9OxIDMk/tSNcWNSSlYrwAQd6r983Hb89rMIrW5nny1JB8dzdw4Avdy7g5E1qgCQYej41mHO+iQ5q0YsiHQrZuOUK/3c24AWLSbtBctSEuRm7hbsdjlL35lCFas2n/ChjrHBfekR0NbH8vf8MaCIj4+C SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1305;20:xtfRkJFThpyoX72opHTaqE5HJbK8tH8PMu4JbOiM8EkmgygmI+jFje6F5R0g2/KOcuOppZn+KtXw064LGdKls2qb7sB92OzB8gOgq7CrmZdjWFsOtaD1MPfKss+zpIaemu1wEV7RfEpddc2S7Isao4KvC76zAosJOp9pdxSXIeNU67v4dLGd/DTG6wqP3F6ZQ0UnPu+v4qQcCrO8meehuPZO6YVUJ2evyL3dFPEVvGAVy5mtR4qE6wI+6ZcoMSXR X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2016 15:58:59.9852 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB1305 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/27/2016 09:59 AM, Baoyou Xie wrote: > We get 2 warnings about global functions without a declaration > in the scsi driver when building with W=1: > drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype for 'scsi_requeue_run_queue' [-Wmissing-prototypes] > drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype for 'scsi_evt_thread' [-Wmissing-prototypes] > > in fact, both functiones are declared in drivers/scsi/scsi_scan.c > but need to move the declarationes into scsi_priv.h. Please fix the spelling in the patch title and description (functiones -> functions and declarationes -> declarations). Anyway: Reviewed-by: Bart Van Assche