From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934455AbbDJN4R (ORCPT ); Fri, 10 Apr 2015 09:56:17 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:53704 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932502AbbDJN4O (ORCPT ); Fri, 10 Apr 2015 09:56:14 -0400 From: "Rafael J. Wysocki" To: Mika Westerberg Cc: Darren Hart , ACPI Devel Maling List , Linux Kernel Mailing List Subject: Re: [update][PATCH 4/4] ACPI / scan: Rework modalias creation when "compatible" is present Date: Fri, 10 Apr 2015 16:20:41 +0200 Message-ID: <2051272.l6xehXeSvh@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150410122902.GW1734@lahna.fi.intel.com> References: <4378053.gHTT51U7FJ@vostro.rjw.lan> <5371556.t424ylyKHo@vostro.rjw.lan> <20150410122902.GW1734@lahna.fi.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, April 10, 2015 03:29:02 PM Mika Westerberg wrote: > On Fri, Apr 10, 2015 at 02:34:44PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Subject: ACPI / scan: Rework modalias creation when "compatible" is present > > > > Currently, the ACPI modalias creation covers two mutually exclusive > > cases: If the PRP0001 device ID is present in the device's list of > > ACPI/PNP IDs and the "compatible" property is present in _DSD, the > > created modalias will follow the OF rules of modalias creation. > > Otherwise, ACPI rules are used. > > > > However, that is not really desirable, because the presence of PRP0001 > > in the list of device IDs generally does not preclude using other > > ACPI/PNP IDs with that device and those other IDs may be of higher > > priority. In those cases, the other IDs should take preference over > > PRP0001 and therefore they also should be present in the modalias. > > > > For this reason, rework the modalias creation for ACPI so that it > > shows both the ACPI-style and OF-style modalias strings if the > > device has a non-empty list of ACPI/PNP IDs (other than PRP0001) > > and a valid "compatible" property at the same time. > > > > Signed-off-by: Rafael J. Wysocki > > Works fine now, thanks! > > For the whole series, > > Tested-by: Mika Westerberg Great, thanks for your help! Much appreciated. Rafael