From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758430Ab2IMPx5 (ORCPT ); Thu, 13 Sep 2012 11:53:57 -0400 Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:38913 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758343Ab2IMPxz (ORCPT ); Thu, 13 Sep 2012 11:53:55 -0400 X-IronPort-AV: E=Sophos;i="4.80,417,1344211200"; d="scan'208";a="14526131" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <20562.397.264907.380798@mariner.uk.xensource.com> Date: Thu, 13 Sep 2012 16:53:49 +0100 To: Konrad Rzeszutek Wilk CC: , , Subject: Re: [Xen-devel] [PATCH 09/10] xen/swiotlb: Fix compile warnings when using plain integer instead of NULL pointer. Newsgroups: chiark.mail.xen.devel In-Reply-To: References: <1347306367-28669-1-git-send-email-konrad.wilk@oracle.com> X-Mailer: VM 8.1.0 under 23.2.1 (i486-pc-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Konrad Rzeszutek Wilk writes ("[Xen-devel] [PATCH 09/10] xen/swiotlb: Fix compile warnings when using plain integer instead of NULL pointer."): > arch/x86/xen/pci-swiotlb-xen.c:96:1: warning: Using plain integer as NULL pointer > arch/x86/xen/pci-swiotlb-xen.c:96:1: warning: Using plain integer as NULL pointer This warning is simply wrong for this code: > IOMMU_INIT_FINISH(pci_xen_swiotlb_detect, > - 0, > + NULL, There is (according to the C language specifications) nothing wrong with writing 0 for a null pointer. Nor does CODING_STYLE say that it is forbidden to just write 0. Ian.