From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Michael Jeanson <mjeanson@efficios.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/3] l3mdev icmp error route lookup fixes
Date: Mon, 12 Oct 2020 08:57:43 -0400 (EDT) [thread overview]
Message-ID: <2056270363.16428.1602507463959.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <19cf586d-4c4e-e18c-cd9e-3fde3717a9e1@gmail.com>
----- On Oct 11, 2020, at 7:56 PM, David Ahern dsahern@gmail.com wrote:
> On 10/5/20 9:30 AM, David Ahern wrote:
>> On 9/25/20 1:04 PM, Mathieu Desnoyers wrote:
>>> Hi,
>>>
>>> Here is an updated series of fixes for ipv4 and ipv6 which which ensure
>>> the route lookup is performed on the right routing table in VRF
>>> configurations when sending TTL expired icmp errors (useful for
>>> traceroute).
>>>
>>> It includes tests for both ipv4 and ipv6.
>>>
>>> These fixes address specifically address the code paths involved in
>>> sending TTL expired icmp errors. As detailed in the individual commit
>>> messages, those fixes do not address similar icmp errors related to
>>> network namespaces and unreachable / fragmentation needed messages,
>>> which appear to use different code paths.
>>>
>>> The main changes since the last round are updates to the selftests.
>>>
>>
>> This looks fine to me. I noticed the IPv6 large packet test case is
>> failing; the fib6 tracepoint is showing the loopback as the iif which is
>> wrong:
>>
>> ping6 8488 [004] 502.015817: fib6:fib6_table_lookup: table 255 oif 0
>> iif 1 proto 58 ::/0 -> 2001:db8:16:1::1/0 tos 0 scope 0 flags 0 ==> dev
>> lo gw :: err -113
>>
>> I will dig into it later this week.
>>
>
> I see the problem here -- source address selection is picking ::1. I do
> not have a solution to the problem yet, but its resolution is
> independent of the change in this set so I think this one is good to go.
OK, do you want to pick up the RFC patch series, or should I re-send it
without RFC tag ?
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2020-10-12 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 20:04 [RFC PATCH 0/3] l3mdev icmp error route lookup fixes Mathieu Desnoyers
2020-09-25 20:04 ` [RFC PATCH 1/3] ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2) Mathieu Desnoyers
2020-09-25 20:04 ` [RFC PATCH 2/3] ipv6/icmp: " Mathieu Desnoyers
2020-09-25 20:04 ` [RFC PATCH 3/3] selftests: Add VRF route leaking tests Mathieu Desnoyers
2020-10-05 16:30 ` [RFC PATCH 0/3] l3mdev icmp error route lookup fixes David Ahern
2020-10-11 23:56 ` David Ahern
2020-10-12 12:57 ` Mathieu Desnoyers [this message]
2020-10-12 13:45 ` David Ahern
2020-10-12 14:10 ` Mathieu Desnoyers
2020-10-12 14:26 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2056270363.16428.1602507463959.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjeanson@efficios.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).