From: shyam_iyer@dell.com
To: linux-kernel@vger.kernel.org
Subject: RE: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3)
Date: Thu, 20 Dec 2007 06:15:23 -0500 [thread overview]
Message-ID: <20591791.1198149323148.JavaMail.root@wombat.diezmil.com> (raw)
In-Reply-To: <46A00B48CC54E4468EF6911F877AC4CAE2AB34@blrx3m10.blr.amer.dell.com>
Robert Hancock wrote:
>@@ -1153,6 +1164,15 @@
> pp->notifier_clear_block = pp->gen_block +
> NV_ADMA_NOTIFIER_CLEAR + (4 * ap->port_no);
>
>+ /* Now that the legacy PRD and padding buffer are allocated we can
>+ safely raise the DMA mask to allocate the CPB/APRD table.
>+ These are allowed to fail since we store the value that ends up
>+ being used to set as the bounce limit in slave_config later if
>+ needed. */
>+ pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
>+ pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
>+ pp->adma_dma_mask = *dev->dma_mask;
>+
> mem = dmam_alloc_coherent(dev, NV_ADMA_PORT_PRIV_DMA_SZ,
> &mem_dma, GFP_KERNEL);
This causes my DMA memory to always be above 4GB no matter how much I delay the setting of the 64bit DMA mask. I find that if I set the DMA mask as 32bit and not increase it to 64 bit at all then all my I/O to the DVD rom are fine.
Jeff Garzik wrote:
>I would consider setting the consistent DMA mask to 32-bit, and setting
>the overall mask to 64-bit.
>Seems like that would solve the problem?
I agree and I have tested that it is working.
-Shyam Iyer
--
This message was sent on behalf of shyam_iyer@dell.com at openSubscriber.com
http://www.opensubscriber.com/message/linux-kernel@vger.kernel.org/8218887.html
next prev parent reply other threads:[~2007-12-20 11:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 2:04 [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v3) Robert Hancock
2007-11-23 15:22 ` Mark Lord
2007-11-23 17:30 ` Morrison, Tom
2007-11-23 17:46 ` Mark Lord
2007-11-23 18:47 ` Morrison, Tom
2007-11-23 20:40 ` Mark Lord
2007-11-24 0:13 ` Robert Hancock
2007-11-24 0:20 ` Jeff Garzik
2007-11-24 0:31 ` Robert Hancock
2007-11-24 2:48 ` Mark Lord
2007-11-24 5:12 ` Tejun Heo
2007-12-04 22:17 ` Jeff Garzik
2007-12-05 1:09 ` Robert Hancock
2007-12-28 21:37 ` Robert Hancock
2007-12-08 18:36 ` Robert Hancock
2007-12-17 11:44 ` shyam_iyer
2007-12-17 16:17 ` shyam_iyer
2007-12-18 2:50 ` Tejun Heo
2007-12-18 3:52 ` Tejun Heo
2007-12-18 10:22 ` Shyam_Iyer
2007-12-18 12:12 ` Shyam_Iyer
2007-12-20 11:15 ` shyam_iyer [this message]
2007-12-17 11:47 ` shyam_iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20591791.1198149323148.JavaMail.root@wombat.diezmil.com \
--to=shyam_iyer@dell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).