From: Markus Elfring <Markus.Elfring@web.de>
To: linux-tegra@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>
Cc: JC Kuo <jckuo@nvidia.com>, Jonathan Hunter <jonathanh@nvidia.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Thierry Reding <treding@nvidia.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Kangjie Lu <kjlu@umn.edu>,
Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
Dan Carpenter <dan.carpenter@oracle.com>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: drivers/phy/tegra: Completion for exception handling in probe functions with SmPL?
Date: Wed, 30 Oct 2019 21:50:17 +0100 [thread overview]
Message-ID: <205e2b3a-2934-f5d0-6b12-59beee0d58fa@web.de> (raw)
In-Reply-To: <161bbb97-09d9-f128-bd25-ef9348534144@web.de>
> But I stumble on another unexpected test result.
I got more promising results by the following transformation approach.
@adjustment exists@
expression object;
identifier exit;
@@
object = kzalloc(...)
...
if (...)
-{ kfree(object);
goto
- exit
+ release_memory
;
-}
... when any
device_unregister(...);
-exit
+release_memory
:
+kfree(object);
return ERR_PTR(...);
The scope property of such a SmPL rule occasionally needs also more
software development attention.
https://github.com/coccinelle/coccinelle/blob/ed1eb8e06f800739d3992158d36945c0c4c6f0c7/docs/manual/cocci_syntax.tex#L860
I observe that the pretty-printing for the generated source code will need
further improvements (according to the Linux coding style).
Example:
elfring@Sonne:~/Projekte/Linux/next-patched> spatch drivers/phy/tegra/xusb-tegra186.c ~/Projekte/Coccinelle/janitor/complete_exception_handling_in_probe_functions6.cocci
…
@@ -461,10 +461,8 @@ tegra186_usb2_pad_probe(struct tegra_xus
pad->soc = soc;
err = tegra_xusb_pad_init(pad, padctl, np);
- if (err < 0) {
- kfree(usb2);
- goto out;
- }
+ if (err < 0)
+ goto release_memory;
priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk");
if (IS_ERR(priv->usb2_trk_clk)) {
@@ -483,7 +481,8 @@ tegra186_usb2_pad_probe(struct tegra_xus
unregister:
device_unregister(&pad->dev);
-out:
+release_memory :
+kfree(usb2);
return ERR_PTR(err);
}
…
How reasonable do you find the presented update suggestion?
Regards,
Markus
prev parent reply other threads:[~2019-10-30 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 21:20 phy: tegra: xusb: Complete exception handling in five probe functions Markus Elfring
2019-10-29 9:40 ` phy: tegra: xusb: Complete exception handling in " Markus Elfring
2019-10-30 10:44 ` drivers/phy/tegra: Completion for exception handling in probe functions with SmPL? Markus Elfring
2019-10-30 20:50 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=205e2b3a-2934-f5d0-6b12-59beee0d58fa@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=dan.carpenter@oracle.com \
--cc=emamd001@umn.edu \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kishon@ti.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smccaman@umn.edu \
--cc=treding@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).