From: Arnd Bergmann <arnd@arndb.de>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arch@vger.kernel.org, devicetree@vger.kernel.org,
Russ Dill <russ.dill@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawn.guo@freescale.com>,
Tony Lindgren <tony@atomide.com>,
Anson.Huang@freescale.com, Russ Dill <Russ.Dill@ti.com>
Subject: Re: [RFC PATCH 1/2] asm-generic: io: Add exec versions of ioremap
Date: Wed, 26 Nov 2014 22:32:47 +0100 [thread overview]
Message-ID: <2060921.TrTof4X6qj@wuerfel> (raw)
In-Reply-To: <cb5e9dd7bd71b13551cd3f32f28feb405ea9fcdd.1417029918.git.d-gerlach@ti.com>
On Wednesday 26 November 2014 15:14:00 Dave Gerlach wrote:
> @@ -66,6 +66,11 @@ extern void ioport_unmap(void __iomem *);
> #define ioremap_wc ioremap_nocache
> #endif
>
> +#ifndef ARCH_HAS_IOREMAP_EXEC
> +#define ioremap_exec ioremap
> +#define ioremap_exec_nocache ioremap_nocache
> +#endif
> +
> #ifdef CONFIG_PCI
> /* Destroy a virtual mapping cookie for a PCI BAR (memory or IO) */
> struct pci_dev;
>
ioremap and ioremap_nocache are the same, and there is no
architecture-independent interface to map an MMIO range as
cached because a lot of architectures can't do that.
Also, I think there are architectures that cannot execute
from uncached memory, so I think adding this as a generic
API is not a good idea.
Arnd
next prev parent reply other threads:[~2014-11-26 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 21:13 [RFC PATCH 0/2] Add ioremap_exec enhancements Dave Gerlach
2014-11-26 21:14 ` [RFC PATCH 1/2] asm-generic: io: Add exec versions of ioremap Dave Gerlach
2014-11-26 21:32 ` Arnd Bergmann [this message]
2014-11-26 21:14 ` [RFC PATCH 2/2] lib: devres: Add exec versions of devm_ioremap_resource and friends Dave Gerlach
2014-11-27 9:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2060921.TrTof4X6qj@wuerfel \
--to=arnd@arndb.de \
--cc=Anson.Huang@freescale.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=russ.dill@ti.com \
--cc=shawn.guo@freescale.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).