From: Stefan Wahren <stefan.wahren@i2se.com>
To: YueHaibing <yuehaibing@huawei.com>,
broonie@kernel.org, eric@anholt.net, f.fainelli@gmail.com,
rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH -next] spi: bcm2835aux: remove unneeded NULL check of devm_clk_get
Date: Wed, 23 Jan 2019 17:16:05 +0100 (CET) [thread overview]
Message-ID: <2064917135.710926.1548260165940@email.ionos.de> (raw)
In-Reply-To: <20190123070507.15404-1-yuehaibing@huawei.com>
> YueHaibing <yuehaibing@huawei.com> hat am 23. Januar 2019 um 08:05 geschrieben:
>
>
> Fix a static code checker warning:
> drivers/spi/spi-bcm2835aux.c:460
> bcm2835aux_spi_probe() warn: passing zero to 'PTR_ERR'
>
> In case of error, the function devm_clk_get() returns ERR_PTR()
> and not returns NULL.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
next prev parent reply other threads:[~2019-01-23 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 7:05 [PATCH -next] spi: bcm2835aux: remove unneeded NULL check of devm_clk_get YueHaibing
2019-01-23 16:16 ` Stefan Wahren [this message]
2019-01-23 17:58 ` Applied "spi: bcm2835aux: remove unneeded NULL check of devm_clk_get" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2064917135.710926.1548260165940@email.ionos.de \
--to=stefan.wahren@i2se.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).