From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495CCC433ED for ; Thu, 20 May 2021 02:00:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AE0D611AE for ; Thu, 20 May 2021 02:00:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbhETCBk (ORCPT ); Wed, 19 May 2021 22:01:40 -0400 Received: from linux.microsoft.com ([13.77.154.182]:60098 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229808AbhETCBh (ORCPT ); Wed, 19 May 2021 22:01:37 -0400 Received: from [192.168.254.32] (unknown [47.187.214.213]) by linux.microsoft.com (Postfix) with ESMTPSA id 95B3A20B7178; Wed, 19 May 2021 19:00:16 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 95B3A20B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1621476017; bh=U8QEKQGFiRQOQLEHv8ObhS4iuMjm72aPIoLD5Z21rRg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NgTZCCwk+NyZJh/Q5+8WXfReGR4mxTpJnXOqpoNZOmnLZQ7bIO4nCxxUkvtVtptaF MyivxqYXEA+qoVEVQ7A43OSK60aAKmXZaGdi/NUZUwciCqMRdsGgbQCChSFczo9LPI 9cwM+2aY2NnzBKrJA1lmL9Wn/mB+rQuUCTzlJ4Y0= Subject: Re: [RFC PATCH v4 2/2] arm64: Create a list of SYM_CODE functions, blacklist them in the unwinder To: Mark Brown Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <68eeda61b3e9579d65698a884b26c8632025e503> <20210516040018.128105-1-madvenka@linux.microsoft.com> <20210516040018.128105-3-madvenka@linux.microsoft.com> <20210519192730.GI4224@sirena.org.uk> From: "Madhavan T. Venkataraman" Message-ID: <2067fb27-34ba-8b7e-e6ef-505796316970@linux.microsoft.com> Date: Wed, 19 May 2021 21:00:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210519192730.GI4224@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks a lot! Madhavan On 5/19/21 2:27 PM, Mark Brown wrote: > On Sat, May 15, 2021 at 11:00:18PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> The unwinder should check if the return PC falls in any function that >> is considered unreliable from an unwinding perspective. If it does, >> mark the stack trace unreliable. > > Other than the naming issue this makes sense to me, I'll try to go > through the first patch properly in the next few days. >