From: "Greenman, Gregory" <gregory.greenman@intel.com>
To: "kvalo@kernel.org" <kvalo@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>
Cc: "Coelho, Luciano" <luciano.coelho@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"rafael@kernel.org" <rafael@kernel.org>,
"Berg, Johannes" <johannes.berg@intel.com>,
"Errera, Nathan" <nathan.errera@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>
Subject: Re: [PATCH 1/2] thermal/drivers/iwlwifi: Use generic thermal_zone_get_trip() function
Date: Tue, 18 Oct 2022 09:38:38 +0000 [thread overview]
Message-ID: <2068f7dc76b57ae72277f072c7c6188edcdcb95c.camel@intel.com> (raw)
In-Reply-To: <f327dfc4-cd67-930c-a011-8cc2c58d7668@linaro.org>
On Fri, 2022-10-14 at 12:21 +0200, Daniel Lezcano wrote:
> On 14/10/2022 12:15, Kalle Valo wrote:
> > Daniel Lezcano <daniel.lezcano@linaro.org> writes:
> >
> > > The thermal framework gives the possibility to register the trip
> > > points with the thermal zone. When that is done, no get_trip_* ops are
> > > needed and they can be removed.
> > >
> > > The get_trip_temp, get_trip_hyst and get_trip_type are handled by the
> > > get_trip_point().
> > >
> > > The set_trip_temp() generic function does some checks which are no
> > > longer needed in the set_trip_point() ops.
> > >
> > > Convert ops content logic into generic trip points and register them
> > > with the thermal zone.
> > >
> > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > > ---
> > > drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 +-
> > > drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 71 ++++----------------
> > > 2 files changed, 13 insertions(+), 60 deletions(-)
> >
> > The subject should begin with "wifi: iwlwifi: ".
> >
> > I don't see patch 2. Via which tree is the plan for this patch?
>
> patch 2 are similar changes but related to the mellanox driver.
>
> This is the continuation of the trip point rework:
>
> https://lore.kernel.org/netdev/20221003092602.1323944-22-daniel.lezcano@linaro.org/t/
>
> This patch is planned to go through the thermal tree
>
> Sorry I should have mentioned that.
>
As Kalle commented above, the subject should start with wifi: iwlwifi:
The commit itself seems fine to me.
Acked-by: Gregory Greenman <gregory.greenman@intel.com>
next prev parent reply other threads:[~2022-10-18 9:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 7:32 [PATCH 1/2] thermal/drivers/iwlwifi: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-10-14 7:32 ` [PATCH 2/2] thermal/drivers/mellanox: " Daniel Lezcano
2022-10-18 6:28 ` Ido Schimmel
2022-10-25 7:02 ` Daniel Lezcano
2022-10-25 10:32 ` Ido Schimmel
2022-10-30 17:24 ` Vadim Pasternak
2022-11-06 18:13 ` Vadim Pasternak
2022-10-14 10:15 ` [PATCH 1/2] thermal/drivers/iwlwifi: " Kalle Valo
2022-10-14 10:21 ` Daniel Lezcano
2022-10-18 9:38 ` Greenman, Gregory [this message]
2022-10-19 6:04 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2068f7dc76b57ae72277f072c7c6188edcdcb95c.camel@intel.com \
--to=gregory.greenman@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=miriam.rachel.korenblit@intel.com \
--cc=nathan.errera@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).