From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423094AbcFHI7n (ORCPT ); Wed, 8 Jun 2016 04:59:43 -0400 Received: from terminus.zytor.com ([198.137.202.10]:54866 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbcFHI7l (ORCPT ); Wed, 8 Jun 2016 04:59:41 -0400 Subject: Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs To: Ingo Molnar , Peter Zijlstra References: <1465342269-492350-1-git-send-email-hpa@linux.intel.com> <1465342269-492350-3-git-send-email-hpa@linux.intel.com> <20160608074956.GO30154@twins.programming.kicks-ass.net> <20160608082835.GB9645@gmail.com> Cc: "H. Peter Anvin" , Thomas Gleixner , Linux Kernel Mailing List , Andy Lutomirski , Borislav Petkov From: "H. Peter Anvin" Message-ID: <2074cf4f-2074-98be-809f-3bc33db8169a@zytor.com> Date: Wed, 8 Jun 2016 01:58:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160608082835.GB9645@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/16 01:28, Ingo Molnar wrote: > > It does matter: > > In file included from arch/x86/kernel/cpu/common.c:21:0: > ./arch/x86/include/asm/archrandom.h:95:20: error: redefinition of ‘arch_get_random_long’ > static inline bool arch_get_random_long(unsigned long *v) > In file included from ./arch/x86/include/asm/stackprotector.h:43:0, > include/linux/random.h:98:20: note: previous definition of ‘arch_get_random_long’ was here > Actually this is an indication of a major bug, quite possibly pre-existing; we somehow are trying to include both the stub and the non-stub version of arch_get_random_long(), which is an obvious no-no. I will look at it in the morning (02:00 here.) -hpa