From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9213C433E1 for ; Tue, 28 Jul 2020 04:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C45E20759 for ; Tue, 28 Jul 2020 04:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="LwgWJaS0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726407AbgG1Ekt (ORCPT ); Tue, 28 Jul 2020 00:40:49 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:62653 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbgG1Eks (ORCPT ); Tue, 28 Jul 2020 00:40:48 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595911248; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=0jt/lIUS0O6MgqaTNYHqWmRMSlQq28krUPIbICxs6KU=; b=LwgWJaS0OFBE1fo+2qLvmNFwpGK9K6LA8nhimkAPc/H/6HFvRPcR6uREFr4bVaJQxHpU6se1 d55j8j4rjFnOJeif5o5hNFdcR5z19lQnAozf8t9S06HtVVc0+RIWFrb6LfWDOX7Ah7N/yMp8 vOlYrQJsStx9Kp+62qTn/QLpoUA= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n17.prod.us-west-2.postgun.com with SMTP id 5f1fac2c49176bd382b7879e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 28 Jul 2020 04:40:12 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4052CC43391; Tue, 28 Jul 2020 04:40:12 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 933BEC433C6; Tue, 28 Jul 2020 04:40:11 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Jul 2020 10:10:11 +0530 From: Sai Prakash Ranjan To: Bjorn Andersson Cc: Andy Gross , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Mathieu Poirier , Suzuki K Poulose , mike.leach@linaro.org, Jonathan Marek Subject: Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR In-Reply-To: <20200727205834.GA202429@builder.lan> References: <2312c9a10e7251d69e31e4f51c0f1d70e6f2f2f5.1591708204.git.saiprakash.ranjan@codeaurora.org> <20200621072213.GG128451@builder.lan> <20200727205834.GA202429@builder.lan> Message-ID: <207e6b6a297d5ce1bdcac204e297389b@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-28 02:28, Bjorn Andersson wrote: > On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > >> Hi Bjorn, >> >> On 2020-06-21 13:39, Sai Prakash Ranjan wrote: >> > Hi Bjorn, >> > >> > On 2020-06-21 12:52, Bjorn Andersson wrote: >> > > On Tue 09 Jun 06:30 PDT 2020, Sai Prakash Ranjan wrote: >> > > >> > > > Define iommus property for Coresight ETR component in >> > > > SC7180 SoC with the SID and mask to enable SMMU >> > > > translation for this master. >> > > > >> > > >> > > We don't have &apps_smmu in linux-next, as we've yet to figure out how >> > > to disable the boot splash or support the stream mapping handover. >> > > >> > > So I'm not able to apply this. >> > > >> > >> > This is for SC7180 which has apps_smmu not SM8150. >> > >> >> Please let me know if this needs further explanation. >> > > I must have commented on the wrong patch, sorry about that. The SM8150 > patch in this series does not compile due to the lack of &apps_smmu. > > I've picked the other 3 patches. > Thanks Bjorn, I can resend SM8150 coresight change when SMMU support lands for it since coresight ETR won't work without it on android bootloaders. As for the other 3 patches, Patch 1 and Patch 2 will apply cleanly to the right coresight nodes but due to the missing unique context in Patch 3, it could be applied to some other node. We had to upload this change 3 times in chromium tree to get it applied to the right replicator node :) and this property in Patch 3 is important to fix a hard lockup. I'm not sure why this patch is missing the proper context :/ I couldn't find the changes yet in qcom/for-next or other branches to see if it is applied to right replicator node. In case you haven't applied it yet, Patch 3 change should be applied to "replicator@6b06000" node. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation