From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>,
cl@rock-chips.com, Kever Yang <kever.yang@rock-chips.com>
Cc: robh+dt@kernel.org, jagan@amarulasolutions.com, wens@csie.org,
uwe@kleine-koenig.org, mail@david-bauer.net,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
jensenhuang@friendlyarm.com, michael@amarulasolutions.com,
cnsztl@gmail.com, devicetree@vger.kernel.org,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-i2c@vger.kernel.org, jay.xu@rock-chips.com,
shawn.lin@rock-chips.com, david.wu@rock-chips.com,
zhangqing@rock-chips.com, huangtao@rock-chips.com,
wim@linux-watchdog.org, linux@roeck-us.net, jamie@jamieiles.com,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 6/7] arm64: dts: rockchip: add core dtsi for RK3568 SoC
Date: Tue, 27 Apr 2021 09:48:41 +0200 [thread overview]
Message-ID: <2088315.NnIJQXNAa5@diego> (raw)
In-Reply-To: <c2e96d99-3af5-3f22-78de-f6eff18b9c24@rock-chips.com>
Hi,
Am Dienstag, 27. April 2021, 05:45:03 CEST schrieb Kever Yang:
> Hi Johan, Heiko,
>
> On 2021/4/26 下午8:16, Johan Jonker wrote:
> > ===
> >
> > compatible = "rockchip,rk3568";
> > Maybe add this together with other rkXXXX SoCs to rockchip.yaml on top
> > of board list ???
> > Please advise.
I don't think so. I.e. the rockchip,rk3568 compatible is not supposed be
standing alone somewhere, but should always be combined with a board-
compatible. Same as the rk3568.dtsi should not be used alone but included
into a board dts.
And patch7 does this by adding the necessary entry to the board list.
> This rockchip.yaml is now describe boards without any sort, it would be
> better to refactor and sort in two level:
> - soc level
> - board level base on the same soc.
The sorting in rockchip.yaml is supposed to be alphabetically by description.
(vendor + boardname)
My intention for this was to allow readers to find their board to get
the matching compatible - and I like that ordering somehow ;-) .
So I don't think there are bigger changes necessary to rockchip.yaml
Heiko
next prev parent reply other threads:[~2021-04-27 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 9:42 [PATCH v2 0/7] arm64: dts: rockchip: add basic dtsi/dts files for RK3568 SoC cl
2021-04-25 9:42 ` [PATCH v2 1/7] dt-bindings: i2c: i2c-rk3x: add description for rk3568 cl
2021-04-25 9:42 ` [PATCH v2 2/7] dt-bindings: serial: snps-dw-apb-uart: " cl
2021-04-25 9:42 ` [PATCH v2 3/7] dt-bindings: mmc: rockchip-dw-mshc: " cl
2021-04-25 9:42 ` [PATCH v2 4/7] dt-bindings: watchdog: dw-wdt: " cl
2021-04-25 9:44 ` [PATCH v2 5/7] arm64: dts: rockchip: add generic pinconfig settings used by most Rockchip socs cl
2021-04-25 9:44 ` [PATCH v2 6/7] arm64: dts: rockchip: add core dtsi for RK3568 SoC cl
2021-04-25 10:28 ` Marc Zyngier
2021-04-26 9:21 ` 陈亮
2021-04-26 12:16 ` Johan Jonker
2021-04-27 3:45 ` Kever Yang
2021-04-27 7:48 ` Heiko Stübner [this message]
2021-04-27 7:41 ` Johan Jonker
2021-04-27 8:07 ` Heiko Stübner
2021-04-28 3:51 ` 陈亮
2021-04-25 9:44 ` [PATCH v2 7/7] arm64: dts: rockchip: add basic dts for RK3568 EVB cl
2021-04-27 7:50 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2088315.NnIJQXNAa5@diego \
--to=heiko@sntech.de \
--cc=cl@rock-chips.com \
--cc=cnsztl@gmail.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=huangtao@rock-chips.com \
--cc=jagan@amarulasolutions.com \
--cc=jamie@jamieiles.com \
--cc=jay.xu@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=jensenhuang@friendlyarm.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mail@david-bauer.net \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=uwe@kleine-koenig.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).