From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Mutanen, Mikko" <Mikko.Mutanen@fi.rohmeurope.com>,
"sre@kernel.org" <sre@kernel.org>,
"Laine, Markus" <Markus.Laine@fi.rohmeurope.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] power: (regmap:) Add linear_range helper
Date: Tue, 18 Feb 2020 07:23:38 +0000 [thread overview]
Message-ID: <208a81c87e944c69d95da85d7fd0f3ea2bd61547.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <375c7756fca56de4f2f85d1a1a4e0b01dadc290b.camel@fi.rohmeurope.com>
Morning Mark,
On Fri, 2020-02-14 at 14:32 +0200, Matti Vaittinen wrote:
> On Fri, 2020-02-14 at 11:47 +0000, Mark Brown wrote:
> > On Wed, Feb 12, 2020 at 06:56:37AM +0000, Vaittinen, Matti wrote:
> > > On Tue, 2020-02-11 at 19:06 +0000, Mark Brown wrote:
> > > >
> >
> > It is a bit but I think that's solvable with some refactoring in
> > place
> > (eg, pushing things into a smaller struct embedded in the main
> > regulator
> > one and then moving them out). I might look at it myself if nobody
> > else
> > gets to it first...
>
> I need something like this in order to convert BD99954 current and
> voltage values to register values. I will happily use what-ever you
> do
> pull together - but if you don't feel like doing it now I might look
> at
> the regulator part while I am working with BD99954 anyways. Please
> just
> let me know if you want me to see if I can pull the range stuff out
> of
> regulator area.
Just to avoid duplicate work - I started working with this. Please let
me know if you are already working on it so I am not doing this in
vain.
By the way - do you have some nice test cases for regulators hidden
somewhere? If so, do you think you could share them? I sure have some
for BD718x7 but they are somewhat clumsy and require special HW. (I've
never liked unit-tests but I must admit there are some specific cases
where they would be pretty usable).
Best Regards,
Matti Vaittinen
next prev parent reply other threads:[~2020-02-18 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 12:11 [RFC PATCH 0/3] Support ROHM BD99954 charger IC Matti Vaittinen
2020-02-10 12:11 ` [RFC PATCH 1/3] dt_bindings: ROHM BD99954 Charger Matti Vaittinen
2020-02-10 13:00 ` Vaittinen, Matti
2020-02-10 12:13 ` [RFC PATCH 2/3] power: (regmap:) Add linear_range helper Matti Vaittinen
2020-02-11 19:06 ` Mark Brown
2020-02-12 6:56 ` Vaittinen, Matti
2020-02-14 11:47 ` Mark Brown
2020-02-14 12:32 ` Vaittinen, Matti
2020-02-18 7:23 ` Vaittinen, Matti [this message]
2020-02-18 13:49 ` Mark Brown
2020-02-19 8:14 ` Vaittinen, Matti
2020-02-10 12:13 ` [RFC PATCH 3/3] power: supply: Support ROHM bd99954 charger Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=208a81c87e944c69d95da85d7fd0f3ea2bd61547.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=Markus.Laine@fi.rohmeurope.com \
--cc=Mikko.Mutanen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).