linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sameer Pujar <spujar@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>, <perex@perex.cz>,
	<tiwai@suse.com>, <robh+dt@kernel.org>
Cc: <spujar@nvidia.com>, <devicetree@vger.kernel.org>,
	<alsa-devel@alsa-project.org>, <atalambedu@nvidia.com>,
	<linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
	<jonathanh@nvidia.com>, <viswanathl@nvidia.com>,
	<sharadg@nvidia.com>, <broonie@kernel.org>,
	<thierry.reding@gmail.com>, <linux-tegra@vger.kernel.org>,
	<rlokhande@nvidia.com>, <mkumard@nvidia.com>,
	<dramesh@nvidia.com>
Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver
Date: Mon, 27 Jan 2020 10:38:39 +0530	[thread overview]
Message-ID: <208e3f8b-75ca-9bb0-ad43-7489709fcae0@nvidia.com> (raw)
In-Reply-To: <8a3259b7-6875-236a-b16c-cd8e023cc8b2@gmail.com>



On 1/24/2020 9:55 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 24.01.2020 06:27, Sameer Pujar пишет:
>>
>> On 1/24/2020 6:58 AM, Dmitry Osipenko wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> 20.01.2020 17:23, Sameer Pujar пишет:
>>> [snip]
>>>> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg)
>>>> +{
>>>> +     struct tegra_admaif *admaif = dev_get_drvdata(dev);
>>>> +     unsigned int ch_stride = TEGRA_ADMAIF_CHANNEL_REG_STRIDE;
>>>> +     unsigned int num_ch = admaif->soc_data->num_ch;
>>>> +     unsigned int rx_base = admaif->soc_data->rx_base;
>>>> +     unsigned int tx_base = admaif->soc_data->tx_base;
>>>> +     unsigned int global_base = admaif->soc_data->global_base;
>>>> +     unsigned int reg_max =
>>>> admaif->soc_data->regmap_conf->max_register;
>>>> +     unsigned int rx_max = rx_base + (num_ch * ch_stride);
>>>> +     unsigned int tx_max = tx_base + (num_ch * ch_stride);
>>>> +
>>>> +     if ((reg >= rx_base) && (reg < rx_max)) {
>>> The braces are not needed around the comparisons because they precede
>>> the AND. Same for all other similar occurrences in the code.
>> While that is true, some prefer to use explicit braces to make it more
>> readable.
>> In the past I was told to use explicitly in such cases.
> At least most of code in kernel (I've seen) doesn't have superfluous
> parens (the curvy thingies actually should be the braces). Readability
> is arguable in this case, I'm finding such code a bit more difficult to
> read, although in some cases parens and spacing may help to read more
> complex constructions.

Yes this is subjective and depends on the individual reading the code. It is
confusing every time, for the sender, about which guideline to follow. 
Resending
the patch/series for only this reason may not be really necessary. Since 
I need
to fix couple of issues in this series I may consider removing the 
explicit braces.


  reply	other threads:[~2020-01-27  5:08 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 14:23 [PATCH 0/9] add ASoC components for AHUB Sameer Pujar
2020-01-20 14:23 ` [PATCH 1/9] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-01-20 14:23 ` [PATCH 2/9] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-01-20 15:58   ` [alsa-devel] " Dmitry Osipenko
2020-01-21  4:41     ` Sameer Pujar
2020-01-21 16:04       ` Dmitry Osipenko
2020-01-27  5:11         ` Sameer Pujar
2020-01-28 22:40           ` Dmitry Osipenko
2020-01-20 14:23 ` [PATCH 3/9] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-01-20 14:23 ` [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-01-21  5:15   ` [alsa-devel] " Dmitry Osipenko
2020-01-21 14:21     ` Sameer Pujar
2020-01-21 16:03       ` Dmitry Osipenko
2020-01-22  4:32         ` Sameer Pujar
2020-01-22  6:23           ` Dmitry Osipenko
2020-01-22  7:16             ` Sameer Pujar
2020-01-22 11:52               ` Jon Hunter
2020-01-22 16:27                 ` Dmitry Osipenko
2020-01-23  9:22                   ` Sameer Pujar
2020-01-23 15:16                     ` Dmitry Osipenko
2020-01-24  9:07                       ` Jon Hunter
2020-01-24  9:51                         ` Jon Hunter
2020-01-24 14:04                           ` Dmitry Osipenko
2020-01-27  5:22                             ` Sameer Pujar
2020-01-29  3:41                               ` Dmitry Osipenko
2020-02-14 14:05                                 ` Jon Hunter
2020-02-18  1:00                                   ` Dmitry Osipenko
2020-02-19 16:10                                     ` Sameer Pujar
2020-01-22 16:26               ` Dmitry Osipenko
2020-01-20 14:23 ` [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-01-24  1:18   ` [alsa-devel] " Dmitry Osipenko
2020-01-24  3:39     ` Sameer Pujar
2020-01-24  4:28       ` Dmitry Osipenko
2020-01-27  9:45     ` Jon Hunter
2020-01-20 14:23 ` [PATCH 6/9] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-01-20 14:23 ` [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-01-24  1:28   ` [alsa-devel] " Dmitry Osipenko
2020-01-24  3:27     ` Sameer Pujar
2020-01-24  4:25       ` Dmitry Osipenko
2020-01-27  5:08         ` Sameer Pujar [this message]
2020-01-20 14:23 ` [PATCH 8/9] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-01-20 14:23 ` [PATCH 9/9] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-01-28 10:49 ` [PATCH 0/9] add ASoC components for AHUB Sameer Pujar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=208e3f8b-75ca-9bb0-ad43-7489709fcae0@nvidia.com \
    --to=spujar@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=atalambedu@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=dramesh@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=perex@perex.cz \
    --cc=rlokhande@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sharadg@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=viswanathl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).