From: Heiko Stuebner <heiko@sntech.de>
To: dri-devel@lists.freedesktop.org
Cc: Lee Jones <lee.jones@linaro.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-pwm@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
kernel@collabora.com, cl@rock-chips.com
Subject: Re: [PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API
Date: Fri, 28 Sep 2018 15:21:47 +0200 [thread overview]
Message-ID: <2092357.WrANtTvkTV@phil> (raw)
In-Reply-To: <20180910144924.GU28860@dell>
Hi Lee,
Am Montag, 10. September 2018, 16:49:24 CEST schrieb Lee Jones:
> On Tue, 14 Aug 2018, Enric Balletbo i Serra wrote:
>
> > The "atomic" API allows us to configure PWM period and duty_cycle and
> > enable it in one call.
> >
> > The patch also moves the pwm_init_state just before any use of the
> > pwm_state struct, this fixes a potential bug where pwm_get_state
> > can be called before pwm_init_state.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> >
> > Changes in v3:
> > - Get rid of duty_cycle variable from pwm_backlight_update_status.
> > - Get rid of pb->enabled and use only the status.enabled variable.
> > - Make power_on match power_off.
> > - Do not share status between ...update_status and ...power_on
> >
> > Changes in v2:
> > - Do not force the PWM be off in the first call to pwm_apply_state.
> > - Delayed applying the state until we know what the period is.
> > - Removed pb->period as after the conversion is not needed.
> >
> > drivers/video/backlight/pwm_bl.c | 81 +++++++++++++++++---------------
> > 1 file changed, 42 insertions(+), 39 deletions(-)
>
> Applied, thanks.
did this miss some push or so, because looking at [0], I don't see
any new patches for a while now?
Heiko
[0] https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/
next prev parent reply other threads:[~2018-09-28 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 16:50 [PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API Enric Balletbo i Serra
2018-08-15 13:59 ` Daniel Thompson
2018-08-21 12:48 ` Heiko Stuebner
2018-09-10 14:49 ` Lee Jones
2018-09-28 13:21 ` Heiko Stuebner [this message]
2018-10-09 6:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2092357.WrANtTvkTV@phil \
--to=heiko@sntech.de \
--cc=b.zolnierkie@samsung.com \
--cc=cl@rock-chips.com \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).