From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967D6C433E1 for ; Thu, 13 Aug 2020 19:58:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75FA720716 for ; Thu, 13 Aug 2020 19:58:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Sa29hv4n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726593AbgHMT6t (ORCPT ); Thu, 13 Aug 2020 15:58:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbgHMT6t (ORCPT ); Thu, 13 Aug 2020 15:58:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AA65C061757; Thu, 13 Aug 2020 12:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Subject:Cc:From:To:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=nJ8XtxrvF6PfqLWB3lP2qE8CmRj4uuFVhReQWgn4JaA=; b=Sa29hv4nZ2Yn/5b5d3KvgO97mE n6+plK6ybXlXKPZn8Gc/dbm1JOgkh0y7Ssx82Hf5ENZ1iCpHVK9U2TvObuV+QCmLYhVLLUe3CKiAY htX+7L4aQumZ/c0tMSjI7M7qhZo/Q0HjhKURc17Ry6VrfOJV7Gjp2F2YYDfYQ3kUxDISNd70d6t+M LnVZVm/SoTm391QP+ZPZmbKL7kxgB7QIZVIyv9rbB2Jwz4AxNPesb6yhyvWrWGck6oMjp5b4V7RED fr7tIOexZgh2EdYMfEZt+6bu0NvcMo4ELiZrei5w0+jVxOMzXHD6zKmk/Kgac52xE7ShQa7SYM1C8 uaXoB1xg==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6JN5-0006YD-3I; Thu, 13 Aug 2020 19:58:43 +0000 To: LKML , linux-pci , Bjorn Helgaas , jsbarnes@google.com From: Randy Dunlap Cc: Arjan van de Ven , Len Brown , Jacob Pan Subject: [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled Message-ID: <20952e3e-6b06-11e4-aff7-07dfbdc5ee18@infradead.org> Date: Thu, 13 Aug 2020 12:58:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Fix build error when CONFIG_ACPI is not set/enabled by adding the header file which contains a stub for the function in the build error. ../arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’: ../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] acpi_noirq_set(); Signed-off-by: Randy Dunlap Cc: Jacob Pan Cc: Len Brown Cc: Bjorn Helgaas Cc: Jesse Barnes Cc: Arjan van de Ven Cc: linux-pci@vger.kernel.org --- Found in linux-next, but applies to/exists in mainline also. Alternative.1: X86_INTEL_MID depends on ACPI Alternative.2: drop X86_INTEL_MID support arch/x86/pci/intel_mid_pci.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20200813.orig/arch/x86/pci/intel_mid_pci.c +++ linux-next-20200813/arch/x86/pci/intel_mid_pci.c @@ -33,6 +33,7 @@ #include #include #include +#include #define PCIE_CAP_OFFSET 0x100