From: Marcel Holtmann <marcel@holtmann.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Eugene Krasnikov <k.eugene.e@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] wcn36xx: Correct Kconfig dependency
Date: Wed, 9 Nov 2016 21:32:18 +0100 [thread overview]
Message-ID: <20975667-9D09-430C-A70B-D0C38A320C86@holtmann.org> (raw)
In-Reply-To: <1478714571-4841-1-git-send-email-bjorn.andersson@linaro.org>
Hi Bjorn,
> In the case SMD or WCNSS_CTRL are compiled as modules, wcn36xx must be
> compiled as module as well, so we need to mention this dependency.
> But we still want allow the driver to be compiled in case either of
> those are =n, for compile testing reasons.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/net/wireless/ath/wcn36xx/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/Kconfig b/drivers/net/wireless/ath/wcn36xx/Kconfig
> index 591ebaea8265..4b83e87f0b94 100644
> --- a/drivers/net/wireless/ath/wcn36xx/Kconfig
> +++ b/drivers/net/wireless/ath/wcn36xx/Kconfig
> @@ -1,6 +1,8 @@
> config WCN36XX
> tristate "Qualcomm Atheros WCN3660/3680 support"
> depends on MAC80211 && HAS_DMA
> + depends on QCOM_WCNSS_CTRL || QCOM_WCNSS_CTRL=n
> + depends on QCOM_SMD || QCOM_SMD=n
I thought we wanted to move towards being able to compile the WiFi and Bluetooth support without requiring QCOM_SMD.
Regards
Marcel
next prev parent reply other threads:[~2016-11-09 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201611092150.OxpAuHow%fengguang.wu@intel.com>
2016-11-09 18:02 ` [PATCH 1/2] wcn36xx: Correct Kconfig dependency Bjorn Andersson
2016-11-09 20:32 ` Marcel Holtmann [this message]
2016-11-09 20:45 ` Bjorn Andersson
2016-11-09 18:02 ` [PATCH 2/2] soc: qcom: smem_state: Fix include for ERR_PTR() Bjorn Andersson
2016-11-09 20:11 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20975667-9D09-430C-A70B-D0C38A320C86@holtmann.org \
--to=marcel@holtmann.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).