From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763823AbcINS4H (ORCPT ); Wed, 14 Sep 2016 14:56:07 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34313 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763319AbcINSz7 (ORCPT ); Wed, 14 Sep 2016 14:55:59 -0400 From: Heiner Kallweit Subject: [PATCH v2 3/7] leds: gpio: add helper cdev_to_gpio_led_data To: Jacek Anaszewski References: <5432fb03-ea18-a949-ce53-10fedc15f5d9@gmail.com> Cc: "linux-leds@vger.kernel.org" , Linux Kernel Mailing List Message-ID: <209962f6-7f7a-05be-c2e2-682273d9f667@gmail.com> Date: Wed, 14 Sep 2016 20:55:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <5432fb03-ea18-a949-ce53-10fedc15f5d9@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a helper for the container_of as it's used more than once. Signed-off-by: Heiner Kallweit --- v2: - rebased due to removal of patch 2 of the original series --- drivers/leds/leds-gpio.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 10c851e..da4aa8e 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -29,11 +29,16 @@ struct gpio_led_data { gpio_blink_set_t platform_gpio_blink_set; }; +static inline struct gpio_led_data * + cdev_to_gpio_led_data(struct led_classdev *led_cdev) +{ + return container_of(led_cdev, struct gpio_led_data, cdev); +} + static void gpio_led_set(struct led_classdev *led_cdev, enum led_brightness value) { - struct gpio_led_data *led_dat = - container_of(led_cdev, struct gpio_led_data, cdev); + struct gpio_led_data *led_dat = cdev_to_gpio_led_data(led_cdev); int level; if (value == LED_OFF) @@ -63,8 +68,7 @@ static int gpio_led_set_blocking(struct led_classdev *led_cdev, static int gpio_blink_set(struct led_classdev *led_cdev, unsigned long *delay_on, unsigned long *delay_off) { - struct gpio_led_data *led_dat = - container_of(led_cdev, struct gpio_led_data, cdev); + struct gpio_led_data *led_dat = cdev_to_gpio_led_data(led_cdev); led_dat->blinking = 1; return led_dat->platform_gpio_blink_set(led_dat->gpiod, GPIO_LED_BLINK, -- 2.9.2