From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4576CEB64D9 for ; Wed, 14 Jun 2023 08:50:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243771AbjFNIut (ORCPT ); Wed, 14 Jun 2023 04:50:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243474AbjFNIuh (ORCPT ); Wed, 14 Jun 2023 04:50:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F9D31FDA for ; Wed, 14 Jun 2023 01:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686732589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Rsvso4l9koDuzHwHgyAvlpKhmbENWcT5E1vZaroQkI=; b=cPxBqrDHOVWQxXCYy1XNX3eBbzyTeD41HTkDl+qo9J3o28wZnzUwDy1ldW/0oiO5vDRqyz g1hWW8G0Ypd1UwOOeohmGxXBStmV/AZ5Gl1VQ0y0SX+HnQkmgrm0T0idq0Y3ME9zbsT66g Cx4avMgVCqHX8m3kJQmNNIgIYBqSNY4= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-lmyUkCoPNG2qfb6WcLOfRQ-1; Wed, 14 Jun 2023 04:49:48 -0400 X-MC-Unique: lmyUkCoPNG2qfb6WcLOfRQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4f614890d21so5074384e87.2 for ; Wed, 14 Jun 2023 01:49:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686732586; x=1689324586; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3Rsvso4l9koDuzHwHgyAvlpKhmbENWcT5E1vZaroQkI=; b=FeI7s3Rm3zndIljmlw52aTcrhlC2Y3gs0WbLPY/EPQdhKhz8NiNtuw1qPkf2oDBBES 5YGEkR/P1sKfyux0ip2CCY93OyU5vrrTQsABqZS0/99yHO/XaJN1FtjfnMi/7vrAu350 FiuRjqZffZ5g3kH/QsQaZmerbsiiFLVslzyjX8GnlFQGxAOy2llCmIrEIFciGyHsSMw5 5btrXCTafZKZqNnx+m46GMluvnIXcZJbYdtY+X1Vvt3aI05LFs1fxY/440Hey0ZmQijU l0stqIDJeT9iHZ3CsRzITS9KLmlzIJK60fRgQG5jRCyTWpatF7xNou4tpRfzYcLnwI46 d35A== X-Gm-Message-State: AC+VfDyv9c/0wvNbuoa6RrR1ZUTH7AYzeVVewl2WdQ98uK50mFmi0z9+ 8B+mZuh9JcdtDvY4GPd65D6w5e5dxrjVEjtssTMvyxma/uiHHKM7kcU6wiz+0wcgjYEMApNuTbm 0Z6Ip1edz4TqNMQGQmXw0jUee X-Received: by 2002:a19:4312:0:b0:4f4:b28f:6b9c with SMTP id q18-20020a194312000000b004f4b28f6b9cmr6502169lfa.29.1686732586592; Wed, 14 Jun 2023 01:49:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4r4XW6g5a7gzGlx/YsBE42/ZrV5TBz6ylOyFXzEPjbNlpThttCQBG7uP9TbF88yZOz/A7BQg== X-Received: by 2002:a19:4312:0:b0:4f4:b28f:6b9c with SMTP id q18-20020a194312000000b004f4b28f6b9cmr6502133lfa.29.1686732586113; Wed, 14 Jun 2023 01:49:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b200:7d03:23db:ad5:2d21? (p200300cbc704b2007d0323db0ad52d21.dip0.t-ipconnect.de. [2003:cb:c704:b200:7d03:23db:ad5:2d21]) by smtp.gmail.com with ESMTPSA id g26-20020a7bc4da000000b003f60e143d38sm16709642wmk.11.2023.06.14.01.49.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 01:49:45 -0700 (PDT) Message-ID: <20afbea8-fef7-55de-20af-8497273bf11f@redhat.com> Date: Wed, 14 Jun 2023 10:49:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v9 04/42] mm: Re-introduce vm_flags to do_mmap() Content-Language: en-US To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com, szabolcs.nagy@arm.com, torvalds@linux-foundation.org, broonie@kernel.org Cc: Yu-cheng Yu , Peter Collingbourne , Pengfei Xu References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-5-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230613001108.3040476-5-rick.p.edgecombe@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.06.23 02:10, Rick Edgecombe wrote: > From: Yu-cheng Yu > > There was no more caller passing vm_flags to do_mmap(), and vm_flags was > removed from the function's input by: > > commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()"). > > There is a new user now. Shadow stack allocation passes VM_SHADOW_STACK to > do_mmap(). Thus, re-introduce vm_flags to do_mmap(). > > Signed-off-by: Yu-cheng Yu > Co-developed-by: Rick Edgecombe > Signed-off-by: Rick Edgecombe > Reviewed-by: Borislav Petkov (AMD) > Reviewed-by: Peter Collingbourne > Reviewed-by: Kees Cook > Reviewed-by: Kirill A. Shutemov > Acked-by: Mike Rapoport (IBM) > Tested-by: Pengfei Xu > Tested-by: John Allen > Tested-by: Kees Cook Acked-by: David Hildenbrand -- Cheers, David / dhildenb