From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A283FC41513 for ; Mon, 16 Oct 2023 19:48:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232988AbjJPTsS (ORCPT ); Mon, 16 Oct 2023 15:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232228AbjJPTsQ (ORCPT ); Mon, 16 Oct 2023 15:48:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8233A92 for ; Mon, 16 Oct 2023 12:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697485650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIrxwAD379HWttBABnirV+Sle9T8jRy9iSXJzz/TC4U=; b=QdY+FI6r7C5FVetDCc8Gi4cbVJONdtCMfbnN/o7rnz6cJNSMXb5Q+AozZ816b9wzapOy3q LnDXsZepkKu9tZmqDGwv1L9NvgTBAQ9ckkjIoEfFAWemGLRIgNfczmB/ZqeECSoYvANPPL OfppXmyeN7lGPgsZ1f+7GUZfI1tteFM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-0f4ektWePniPnXRMOKDH-A-1; Mon, 16 Oct 2023 15:47:29 -0400 X-MC-Unique: 0f4ektWePniPnXRMOKDH-A-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7756d4d252cso604755385a.1 for ; Mon, 16 Oct 2023 12:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697485649; x=1698090449; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hIrxwAD379HWttBABnirV+Sle9T8jRy9iSXJzz/TC4U=; b=eGPqpmCWT5Enxpz1BzygIFGFLrWL5tQOGKGHkR4Yws1Z0xc8MJ5MES5OOLpRHcDufS GjQpNrRJ3kKHdP/IUwvqMpagaYZ45F/za3T1WvzWaUF+hbt4/ErVeHMCtwIg/0xuIYc7 +4hJYeJjxKXMh9PuYxfn0YRNpRb0o4bF/n6UFU2hKIjkuOdux4ODYHl9kw+cYnXw3CnF tSqiAsPd+S6OwryjcF5K4m8wtoLmF5yyVUS/TTQbE60qEsSDir9PLM3dZfJfeeMn75Zt 5OY0VyXB1Q9DOmIhMl5zWClDHjN0HOKXldF8AwggQYRLlfzbiEePP2ZLBuy9tHvtLlzz G86Q== X-Gm-Message-State: AOJu0YxN4lQHjGws/m6+FqHsC26s6LE9EBOhAGzrqIRtIwOE5sT1N0ks MYXUKshzZwI8JJtEYyGYs1S74iex3sEknFWnoED0G062Xo5J8goSXzGvF0ClUPAA/LnuwbE9oXJ 5B7hwY8K7bw7VV2WyH7wroEm8 X-Received: by 2002:a05:620a:25ce:b0:777:7240:8de with SMTP id y14-20020a05620a25ce00b00777724008demr146999qko.8.1697485648708; Mon, 16 Oct 2023 12:47:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3u6I00hayIaOImQeZghUxCl82gdoyvt4Nd2uprPCzUlhJB397PjkrSk4Pvd5jxnjH++cZDQ== X-Received: by 2002:a05:620a:25ce:b0:777:7240:8de with SMTP id y14-20020a05620a25ce00b00777724008demr146985qko.8.1697485648421; Mon, 16 Oct 2023 12:47:28 -0700 (PDT) Received: from [192.168.43.95] ([37.170.191.221]) by smtp.gmail.com with ESMTPSA id k27-20020a05620a143b00b007742c6823a3sm3226478qkj.108.2023.10.16.12.47.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 12:47:27 -0700 (PDT) Message-ID: <20bdc913-57d2-abe9-d222-d77647281b43@redhat.com> Date: Mon, 16 Oct 2023 21:47:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 04/12] KVM: arm64: PMU: Don't define the sysreg reset() for PM{USERENR,CCFILTR}_EL0 Content-Language: en-US To: Raghavendra Rao Ananta , Oliver Upton , Marc Zyngier Cc: Alexandru Elisei , James Morse , Suzuki K Poulose , Paolo Bonzini , Zenghui Yu , Shaoqin Huang , Jing Zhang , Reiji Watanabe , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20231009230858.3444834-1-rananta@google.com> <20231009230858.3444834-5-rananta@google.com> From: Eric Auger In-Reply-To: <20231009230858.3444834-5-rananta@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/10/23 01:08, Raghavendra Rao Ananta wrote: > From: Reiji Watanabe > > The default reset function for PMU registers (defined by PMU_SYS_REG) > now simply clears a specified register. Use the default one for > PMUSERENR_EL0 and PMCCFILTR_EL0, as KVM currently clears those > registers on vCPU reset (NOTE: All non-RES0 fields of those > registers have UNKNOWN reset values, and the same fields of > their AArch32 registers have 0 reset values). > > No functional change intended. > > Signed-off-by: Reiji Watanabe > Signed-off-by: Raghavendra Rao Ananta > --- > arch/arm64/kvm/sys_regs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 3dbb7d276b0e..08af7824e9d8 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -2180,7 +2180,7 @@ static const struct sys_reg_desc sys_reg_descs[] = { > * in 32bit mode. Here we choose to reset it as zero for consistency. > */ > { PMU_SYS_REG(PMUSERENR_EL0), .access = access_pmuserenr, > - .reset = reset_val, .reg = PMUSERENR_EL0, .val = 0 }, > + .reg = PMUSERENR_EL0, }, > { PMU_SYS_REG(PMOVSSET_EL0), > .access = access_pmovs, .reg = PMOVSSET_EL0 }, > > @@ -2338,7 +2338,7 @@ static const struct sys_reg_desc sys_reg_descs[] = { > * in 32bit mode. Here we choose to reset it as zero for consistency. > */ > { PMU_SYS_REG(PMCCFILTR_EL0), .access = access_pmu_evtyper, > - .reset = reset_val, .reg = PMCCFILTR_EL0, .val = 0 }, > + .reg = PMCCFILTR_EL0, }, > > EL2_REG(VPIDR_EL2, access_rw, reset_unknown, 0), > EL2_REG(VMPIDR_EL2, access_rw, reset_unknown, 0), Reviewed-by: Eric Auger Thanks Eric