From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7295FC4338F for ; Thu, 29 Jul 2021 15:57:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 552F660F21 for ; Thu, 29 Jul 2021 15:57:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238332AbhG2P5f (ORCPT ); Thu, 29 Jul 2021 11:57:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40240 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238174AbhG2P5E (ORCPT ); Thu, 29 Jul 2021 11:57:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627574220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OdUOSn5PsAyIvz/45Ktqnl2uzGhZFKajWTR316l3Z74=; b=bbYtjcoVmU0+FlbJLtmEyn6TMFNDohk9VltIOKevd97vynQdS8iTSoDh7C+OjM1O4fmYoo 3IkpSoFOAj7aeFPfs+zr4GuiGrVC9sb1h/7SeuMXWPaWvWUqOrByW+sazYDC/56yDNMCFG PjijuN8OOA6lUHNc6WweUmJC0kUsuzo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-574-zCwQAm_eMR-kdsRcB_nbgw-1; Thu, 29 Jul 2021 11:56:59 -0400 X-MC-Unique: zCwQAm_eMR-kdsRcB_nbgw-1 Received: by mail-wm1-f70.google.com with SMTP id k5-20020a7bc3050000b02901e081f69d80so937989wmj.8 for ; Thu, 29 Jul 2021 08:56:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OdUOSn5PsAyIvz/45Ktqnl2uzGhZFKajWTR316l3Z74=; b=HhgS8P65HEvzi6Du7D2Ubsz/niEneNOK9oza2dSqlR+s7aGB7wlhbmoHzLj96nfj+s JIHjNLypzqZP/RffKA6DT8SHz1nd7WTdsqtoCj8Rg78EZf7T1oPQ6/uG7PT5wvIIuJMa mmsL7dE9tj2HjIdLFvKFYrx132Cb+0ALjUEqhey8UIab4ljBJjhzXDcwi1VuVFgvyXBz TndSipaUF4aCphdiK/nxHtpRScVeESs/eNbvkZ6JS9/I39E7uqwnuNBHZ7nz9SJRJRqz rnasfWOb060XZ0A3Dm+3q1EfbmplC3lBftAZRJ/8kIb1ZbREdBEzNsQpy9Dd7UmPvQHx C91Q== X-Gm-Message-State: AOAM5311rDSMMys97UJ4F3k9Tnrvv0vEQBu3yJqLcuU7LsIZlltDICai Uh6ddPqd59t24box28+OfDcrBUcVZL+n/X7n4m24gT4QTG4BIjUNQ32hyllrF2Ooyy14s9DOrpk oUDh0ClNCEICVOU33Dyro3mOf X-Received: by 2002:adf:ed4a:: with SMTP id u10mr5502884wro.86.1627574217994; Thu, 29 Jul 2021 08:56:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLgrogS1Ps6UnQ/0VQrtQt2MjSbOfI++E0VYu6WLH7GmA/dcP3gaa//uIkUtCBDdxTYVpodw== X-Received: by 2002:adf:ed4a:: with SMTP id u10mr5502864wro.86.1627574217775; Thu, 29 Jul 2021 08:56:57 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id k17sm4088354wrw.53.2021.07.29.08.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 08:56:57 -0700 (PDT) Subject: Re: [PATCH 1/6] x86/feat_ctl: Add new VMX feature, Tertiary VM-Execution control To: Sean Christopherson , Zeng Guang Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, Dave Hansen , Tony Luck , Kan Liang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kim Phillips , Jarkko Sakkinen , Jethro Beekman , Kai Huang , x86@kernel.org, linux-kernel@vger.kernel.org, Robert Hu , Gao Chao , Robert Hoo References: <20210716064808.14757-1-guang.zeng@intel.com> <20210716064808.14757-2-guang.zeng@intel.com> From: Paolo Bonzini Message-ID: <20d46894-a42f-88fc-124b-9d6662c57bef@redhat.com> Date: Thu, 29 Jul 2021 17:56:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/21 01:44, Sean Christopherson wrote: >> + rdmsr_safe(MSR_IA32_VMX_PROCBASED_CTLS3, &ign, &supported); >> + c->vmx_capability[TERTIARY_CTLS_LOW] = ign; >> + c->vmx_capability[TERTIARY_CTLS_HIGH] = supported; > Assuming only the lower 32 bits are going to be used for the near future (next > few years), what about defining just TERTIARY_CTLS_LOW and then doing: > > /* > * Tertiary controls are 64-bit allowed-1, so unlikely other MSRs, the > * upper bits are ignored (because they're not used, yet...). > */ > rdmsr_safe(MSR_IA32_VMX_PROCBASED_CTLS3, &supported, &ign); > c->vmx_capability[TERTIARY_CTLS_LOW] = supported; > > I.e. punt the ugliness issue down the road a few years. > Or use two new variables low/high instead of supported/ign. Paolo