From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3] console: newport_con: fix an issue about leak related system resources
Date: Fri, 24 Apr 2020 18:54:41 +0200 [thread overview]
Message-ID: <20f37865-5af3-5fb9-8b8f-91f9464e4af3@web.de> (raw)
> The corresponding system resources were not released then.
How do you think about a wording variant like the following?
Subject:
[PATCH v4] console: newport_con: Fix incomplete releasing of system resources
Change description:
* A call of the function do_take_over_console() can fail here.
The corresponding system resources were not released then.
Thus add a call of iounmap() and release_mem_region()
together with the check of a failure predicate.
* Add also a call of release_mem_region() for the completion
of resource clean-up on device removal.
It can be nicer if all patch reviewers (including me) will be explicitly specified
as recipients for such messages, can't it?
Regards,
Markus
next reply other threads:[~2020-04-24 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 16:54 Markus Elfring [this message]
2020-04-26 2:55 ` [PATCH v3] console: newport_con: fix an issue about leak related system resources Dejin Zheng
[not found] <CGME20200423164300eucas1p286ebc9584639c8e8b6311dbf10355808@eucas1p2.samsung.com>
2020-04-23 16:42 ` Dejin Zheng
2020-04-23 21:23 ` Andy Shevchenko
2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20f37865-5af3-5fb9-8b8f-91f9464e4af3@web.de \
--to=markus.elfring@web.de \
--cc=akpm@osdl.org \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).