linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Wei Wang <wei.w.wang@intel.com>,
	virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	mst@redhat.com, cohuck@redhat.com
Cc: pbonzini@redhat.com, dgilbert@redhat.com, pasic@linux.ibm.com
Subject: Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation
Date: Tue, 8 Jan 2019 09:46:04 +0100	[thread overview]
Message-ID: <20f5fb20-612a-fe37-c5e1-af5ecb98f5d3@de.ibm.com> (raw)
In-Reply-To: <5C343688.2060609@intel.com>



On 08.01.2019 06:35, Wei Wang wrote:
> On 01/07/2019 09:49 PM, Christian Borntraeger wrote:
>>
>> On 07.01.2019 08:01, Wei Wang wrote:
>>> virtio-ccw has deadlock issues with reading the config space inside the
>>> interrupt context, so we tweak the virtballoon_changed implementation
>>> by moving the config read operations into the related workqueue contexts.
>>> The config_read_bitmap is used as a flag to the workqueue callbacks
>>> about the related config fields that need to be read.
>>>
>>> The cmd_id_received is also renamed to cmd_id_received_cache, and
>>> the value should be obtained via virtio_balloon_cmd_id_received.
>>>
>>> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
>>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>>> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
>> Together with
>>    virtio_pci: use queue idx instead of array idx to set up the vq
>>    virtio: don't allocate vqs when names[i] = NULL
>>
>> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
> 
> OK. I don't plan to send a new version of the above patches as no changes needed so far.
> 
> Michael, if the above two patches look good to you, please help add the related tested-by
> and reviewed-by tags. Thanks.

Can we also make sure that 

virtio_pci: use queue idx instead of array idx to set up the vq
virtio: don't allocate vqs when names[i] = NULL

also land in stable?


  reply	other threads:[~2019-01-08  8:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07  7:01 [PATCH v3 0/3] virtio-balloon: tweak config_changed Wei Wang
2019-01-07  7:01 ` [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation Wei Wang
2019-01-07 13:44   ` Michael S. Tsirkin
2019-01-07 13:47   ` Michael S. Tsirkin
2019-01-07 13:49   ` Christian Borntraeger
2019-01-08  5:35     ` Wei Wang
2019-01-08  8:46       ` Christian Borntraeger [this message]
2019-01-09 10:35         ` Wei Wang
2019-01-09 12:07           ` Christian Borntraeger
2019-01-09 14:52             ` Michael S. Tsirkin
2019-01-09 18:22               ` Christian Borntraeger
2019-01-09 18:31                 ` Michael S. Tsirkin
2019-01-09 14:49           ` Michael S. Tsirkin
2019-01-15  0:53     ` Michael S. Tsirkin
2019-01-07  7:01 ` [PATCH v3 2/3] virtio-balloon: improve update_balloon_size_func Wei Wang
2019-01-15  1:00   ` Michael S. Tsirkin
2019-01-15  2:18     ` Wei Wang
2019-01-07  7:01 ` [PATCH v3 3/3] virtio_balloon: remove the unnecessary 0-initialization Wei Wang
2019-01-07 14:07   ` Cornelia Huck
2019-01-07 13:40 ` [PATCH v3 0/3] virtio-balloon: tweak config_changed Christian Borntraeger
2019-01-07 13:45 ` Michael S. Tsirkin
2019-01-07 13:50   ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20f5fb20-612a-fe37-c5e1-af5ecb98f5d3@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).