From: Jens Axboe <axboe@kernel.dk>
To: John Garry <john.garry@huawei.com>
Cc: osandov@fb.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.lei@redhat.com
Subject: Re: [PATCH] blk-mq-sched: Fix blk_mq_sched_alloc_tags() error handling
Date: Tue, 27 Jul 2021 16:44:58 -0600 [thread overview]
Message-ID: <20fb9978-af00-0bc6-33d2-c41bfb129cb4@kernel.dk> (raw)
In-Reply-To: <1627378373-148090-1-git-send-email-john.garry@huawei.com>
On 7/27/21 3:32 AM, John Garry wrote:
> If the blk_mq_sched_alloc_tags() -> blk_mq_alloc_rqs() call fails, then we
> call blk_mq_sched_free_tags() -> blk_mq_free_rqs().
>
> It is incorrect to do so, as any rqs would have already been freed in the
> blk_mq_alloc_rqs() call.
>
> Fix by calling blk_mq_free_rq_map() only directly.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-07-27 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 9:32 [PATCH] blk-mq-sched: Fix blk_mq_sched_alloc_tags() error handling John Garry
2021-07-27 10:06 ` Ming Lei
2021-07-27 10:30 ` John Garry
2021-07-27 10:43 ` Ming Lei
2021-07-27 22:44 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20fb9978-af00-0bc6-33d2-c41bfb129cb4@kernel.dk \
--to=axboe@kernel.dk \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).