From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753928AbbKQPbE (ORCPT ); Tue, 17 Nov 2015 10:31:04 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35404 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbbKQPbB (ORCPT ); Tue, 17 Nov 2015 10:31:01 -0500 From: Joshua Clayton To: Alessandro Zummo , Alexandre Belloni , rtc-linux@googlegroups.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] rtc-2123: access the clock offset feature Date: Tue, 17 Nov 2015 07:30:48 -0800 Message-ID: <2107368.j5bIbb5cBF@jclayton-pc> User-Agent: KMail/5.0.2 (Linux/4.2.0-18-generic; KDE/5.15.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, November 04, 2015 07:36:31 AM Joshua Clayton wrote: > Greetings, > This series was prompted by a need to adjust the clock rate of the rtc > The existing code performs a soft reset during probe, which wipes out > several registers including the offset register, which performs adjustments > to the clock rate. > > The first several patches are cleanup, with patch 5 and 6 avoiding the reset, > and patch 9 adding a nice sysfs interface to the clock offset. > > I know that this is not the only rtc to provide a programmable clock offset > I wonder if this interface would make a good addition to the rtc api? > > The rtc chips I have seen list their clock adjustments in parts per million. > I went with parts per billion, since the ppm listed was listed with a > fractional component. > > Joshua Clayton (9): > rtc-pcf2123: Document all registers and useful bits > rtc-pcf2123: clean up reads from the chip > rtc-pcf2123: clean up writes to the rtc chip > rtc-pcf2123: replace magic numbers with defines > rtc-pcf2123: put the chip reset into a function > rtc-pcf2123: avoid resetting the clock if possible > rtc-pcf2123: allow sysfs to accept hexidecimal > rtc-pcf2123: use sysfs groups > rtc-pcf2123: adjust the clock rate via sysfs > > drivers/rtc/rtc-pcf2123.c | 391 ++++++++++++++++++++++++++++++---------------- > 1 file changed, 257 insertions(+), 134 deletions(-) > > Any comments on this series? I realize now that I submitted it during the merge window, so it may have been overlooked. -- ~Joshua Clayton