From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FA9C43217 for ; Mon, 21 Nov 2022 11:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231254AbiKULbc (ORCPT ); Mon, 21 Nov 2022 06:31:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231246AbiKULa5 (ORCPT ); Mon, 21 Nov 2022 06:30:57 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27BF6BEB46 for ; Mon, 21 Nov 2022 03:25:34 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id u11so14141826ljk.6 for ; Mon, 21 Nov 2022 03:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0LaZt3ACXInaeHGhfmj5AITKDzoQ9XKfEEDOaqIk2O0=; b=BRUSEfRJGsvWWGF5jvGT3A+4zaHRmYMnDeIAGSR2J8jFbk3O/fQFLYcNAtBtuJNzNA Z758qjTU04af7RZUIiIcGl2u6c4kRNVeOj980bQLDud5Q9zl1eGxhyjjCIwm2/LpchtM 094jkHX3FjIvA22Ps53rNJNK1h+tCJ8C5zOBmh0Le7BsDC9AOvJKjCrAT+C4Om5GLy6Z rSW+KKGevCyvmdKboat94gzR09K1GGMinS2bKWutIQGhtCY5dpdvp5CFHYL6phYHWwqu pIxP1VFOebmZ/9tfwhqWh8MSutCruPbQ0ZkjSnia2eTk5qrEG/mTR3pvnS2W7vViS0ru OfPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0LaZt3ACXInaeHGhfmj5AITKDzoQ9XKfEEDOaqIk2O0=; b=JLSpu0dpNrJ1TWKqxXicKohgK/IzK8J8oXMNrZjvv6RMsWWqw4McROYpZ5EHcJ9VvR YBEOfCM/jCiDlk7Pm8++Ecyzv00mWwLHf5ntBhU5DWN9P08RCakgQlJ3RK8/5HYJOGZK 5mZFSHEp1MCefW7vEx7b5Ls8fC7Lj24giJqfK5SVD4KdWvp9qAguUVE13XSt4Xsalvhy 30KDS1h91klMCS0+xoPQWF0mTgYzj5TLHYSnSfpqbJ0tHjl0my/r3Fms8qJLokD5DeTT ut/4hT+AU3K1RJOg3gpbMpSJLJNUTVTP5FeZAYc/TDhak86bL58agXQfDVdbQoJv2mUk qN4w== X-Gm-Message-State: ANoB5pkD4vyCTOjUYdEz+DMAnV3BiVmhdZleYmw9fvpqGqXFYfu9BWmT xiMpIJYry1Oy11Jkkm3BM/djpA== X-Google-Smtp-Source: AA0mqf7ux/YX/+/u6vSAVXuunL9tuOFu4V0giRgE9Bkg83kbnZVb+S11qIRAsXrQn4ruGt/m9PkAPQ== X-Received: by 2002:a05:651c:1690:b0:277:2b10:bf69 with SMTP id bd16-20020a05651c169000b002772b10bf69mr130590ljb.392.1669029932504; Mon, 21 Nov 2022 03:25:32 -0800 (PST) Received: from [192.168.1.101] (95.49.32.48.neoplus.adsl.tpnet.pl. [95.49.32.48]) by smtp.gmail.com with ESMTPSA id a15-20020a056512200f00b004917a30c82bsm1985410lfb.153.2022.11.21.03.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 03:25:32 -0800 (PST) Message-ID: <2108bd9f-629f-e871-3cfe-441c28719d52@linaro.org> Date: Mon, 21 Nov 2022 12:25:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/3] arm64: dts: qcom: msm8916-acer-a1-724: Add initial device tree Content-Language: en-US To: "Lin, Meng-Bo" , linux-kernel@vger.kernel.org Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Stephan Gerhold , Nikita Travkin , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20221119194340.91789-1-linmengbo0689@protonmail.com> <20221119194718.92052-1-linmengbo0689@protonmail.com> From: Konrad Dybcio In-Reply-To: <20221119194718.92052-1-linmengbo0689@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.11.2022 20:48, Lin, Meng-Bo wrote: > Acer Iconia Talk S A1-724 is a tablet using the MSM8916 SoC released > in 2014. > > Note: The original firmware from Acer can only boot 32-bit kernels. > To boot arm64 kernels it is necessary to flash 64-bit TZ/HYP firmware > with EDL, e.g. taken from the DragonBoard 410c. This works because Acer > didn't set up (firmware) secure boot. > > Add a device tree for with initial support for: > > - GPIO keys > - pm8916-vibrator > - SDHCI (internal and external storage) > - USB Device Mode > - UART > - WCNSS (WiFi/BT) > - Regulators > > Signed-off-by: Lin, Meng-Bo > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/msm8916-acer-a1-724.dts | 217 ++++++++++++++++++ > 2 files changed, 218 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index afe496a93f94..f38a20074013 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c2.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-asus-z00l.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-huawei-g7.dtb > diff --git a/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts b/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > new file mode 100644 > index 000000000000..acd909551a75 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts > @@ -0,0 +1,217 @@ > +// SPDX-License-Identifier: GPL-2.0-only > + > +/dts-v1/; > + > +#include "msm8916-pm8916.dtsi" > + > +#include > +#include > + > +/* > + * NOTE: The original firmware from Acer can only boot 32-bit kernels. > + * To boot this device tree using arm64 it is necessary to flash 64-bit > + * TZ/HYP firmware (e.g. taken from the DragonBoard 410c). > + * See https://wiki.postmarketos.org/wiki/Acer_Iconia_Talk_S_(acer-a1-724) > + * for suggested installation instructions. > + */ > + > +/ { > + model = "Acer Iconia Talk S A1-724"; > + compatible = "acer,a1-724", "qcom,msm8916"; > + chassis-type = "tablet"; > + > + aliases { > + serial0 = &blsp1_uart2; > + }; > + > + chosen { > + stdout-path = "serial0"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys_default>; > + > + label = "GPIO Buttons"; > + > + button-volume-up { > + label = "Volume Up"; > + gpios = <&msmgpio 107 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + }; > + > + usb_id: usb-id { > + compatible = "linux,extcon-usb-gpio"; > + id-gpio = <&msmgpio 110 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb_id_default>; > + }; > +}; > + > +&blsp1_uart2 { > + status = "okay"; > +}; > + > +&pm8916_resin { > + status = "okay"; > + linux,code = ; > +}; > + > +&pm8916_vib { > + status = "okay"; > +}; > + > +&pronto { > + status = "okay"; > +}; > + > +&sdhc_1 { > + status = "okay"; status last, please. > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc1_clk_on &sdc1_cmd_on &sdc1_data_on>; > + pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off>; > +}; > + > +&sdhc_2 { > + status = "okay"; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off>; > + > + cd-gpios = <&msmgpio 38 GPIO_ACTIVE_HIGH>; > +}; > + > +&usb { > + status = "okay"; > + extcon = <&usb_id>, <&usb_id>; > +}; > + > +&usb_hs_phy { > + extcon = <&usb_id>; > +}; These usb references are not sorted alphabetically. > + > +&smd_rpm_regulators { > + vdd_l1_l2_l3-supply = <&pm8916_s3>; > + vdd_l4_l5_l6-supply = <&pm8916_s4>; > + vdd_l7-supply = <&pm8916_s4>; > + > + s3 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1300000>; > + }; > + > + s4 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2100000>; > + }; > + > + l1 { > + regulator-min-microvolt = <1225000>; > + regulator-max-microvolt = <1225000>; > + }; > + > + l2 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + l4 { > + regulator-min-microvolt = <2050000>; > + regulator-max-microvolt = <2050000>; > + }; > + > + l5 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + l6 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + l7 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + l8 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2900000>; > + }; > + > + l9 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + l10 { > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <2800000>; > + }; > + > + l11 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + regulator-allow-set-load; > + regulator-system-load = <200000>; Please swap these last two properties. Looks good otherwise. Konrad > + }; > + > + l12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + l13 { > + regulator-min-microvolt = <3075000>; > + regulator-max-microvolt = <3075000>; > + }; > + > + l14 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + l15 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + l16 { > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + }; > + > + l17 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2850000>; > + }; > + > + l18 { > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <2700000>; > + }; > +}; > + > +&msmgpio { > + gpio_keys_default: gpio-keys-default-state { > + pins = "gpio107"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + usb_id_default: usb-id-default-state { > + pins = "gpio110"; > + function = "gpio"; > + > + drive-strength = <8>; > + bias-pull-up; > + }; > +};