From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Wong <e@80x24.org>, Thorsten Leemhuis <linux@leemhuis.info>,
workflows@vger.kernel.org, linux-kernel@vger.kernel.org,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
git@vger.kernel.org
Subject: Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:'
Date: Fri, 26 Nov 2021 13:49:16 +0100 [thread overview]
Message-ID: <211126.86h7bzhyfy.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq4k825o6r.fsf@gitster.g>
On Tue, Nov 23 2021, Junio C Hamano wrote:
> Eric Wong <e@80x24.org> writes:
>
>> git send-email's capitalization does annoy me and I've looked
>> into changing it; but there's a bunch of tests and probably
>> dependent code that also need to be updated...
> [...]
> diff --git i/git-send-email.perl w/git-send-email.perl
> index 5262d88ee3..a61134c7d3 100755
> --- i/git-send-email.perl
> +++ w/git-send-email.perl
> @@ -1494,7 +1494,7 @@ sub send_message {
> To: $to${ccline}
> Subject: $subject
> Date: $date
> -Message-Id: $message_id
> +Message-ID: $message_id
> ";
> if ($use_xmailer) {
> $header .= "X-Mailer: git-send-email $gitversion\n";
Perhaps one way to split this & make it more readable is to split this,
i.e. the mesage-id's send-email itself generates & tests, usually it
passes along format-patch's.
> @@ -1789,7 +1789,7 @@ sub process_file {
> $has_mime_version = 1;
> push @xh, $_;
> }
> - elsif (/^Message-Id: (.*)/i) {
> + elsif (/^Message-ID: (.*)/i) {
> $message_id = $1;
> }
> elsif (/^Content-Transfer-Encoding: (.*)/i) {
Not strictly needed due to the /i, maybe splitting out cosmetic changes
would be better?
I also notice we have various hits for "git grep message-id", including
regex checks you didn't update here.
next prev parent reply other threads:[~2021-11-26 13:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 7:33 [RFC PATCH v1 0/1] Create 'Reported:' and 'Reviewed:' tags for links in commit messages Thorsten Leemhuis
2021-11-22 7:33 ` [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:' Thorsten Leemhuis
2021-11-22 16:29 ` Steven Rostedt
2021-11-22 18:50 ` Thorsten Leemhuis
2021-11-22 20:24 ` Steven Rostedt
2021-11-23 8:53 ` Thorsten Leemhuis
2021-11-23 18:52 ` Eric Wong
2021-11-24 1:37 ` Junio C Hamano
2021-11-24 6:12 ` Eric Wong
2021-11-26 12:49 ` Ævar Arnfjörð Bjarmason [this message]
2021-11-24 2:08 ` Ævar Arnfjörð Bjarmason
2021-11-26 7:29 ` Thorsten Leemhuis
2021-11-26 17:11 ` Eric Wong
2021-11-27 19:32 ` Thorsten Leemhuis
2021-11-27 19:52 ` Eric Wong
2021-11-27 20:20 ` Junio C Hamano
2021-11-29 12:03 ` Jani Nikula
2021-11-29 17:10 ` Steven Rostedt
2021-11-29 17:18 ` Junio C Hamano
2021-11-29 19:18 ` Jani Nikula
2021-11-29 17:26 ` Eric Wong
2021-11-29 19:20 ` Jani Nikula
2021-11-30 8:24 ` Geert Uytterhoeven
2021-12-08 13:41 ` Thorsten Leemhuis
2021-12-08 17:02 ` Eric Wong
2021-11-29 22:16 ` Jonathan Corbet
2021-11-30 13:10 ` Thorsten Leemhuis
2021-12-01 12:24 ` Geert Uytterhoeven
2021-11-22 15:12 ` [RFC PATCH v1 0/1] Create 'Reported:' and 'Reviewed:' tags for links in commit messages Konstantin Ryabitsev
2021-11-22 17:04 ` Steven Rostedt
2021-11-22 18:40 ` Thorsten Leemhuis
2021-11-22 18:48 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211126.86h7bzhyfy.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=corbet@lwn.net \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).