From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752767AbdHJQAV (ORCPT ); Thu, 10 Aug 2017 12:00:21 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:53488 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbdHJQAU (ORCPT ); Thu, 10 Aug 2017 12:00:20 -0400 Subject: Re: [V4 1/2] phy: ralink-usb: add driver for Mediatek/Ralink To: James Hogan , , , , CC: John Crispin , , References: <1502271340-29001-1-git-send-email-harvey.hunt@imgtec.com> From: Harvey Hunt Message-ID: <21122b7e-dd7d-1a83-f4c4-2fbd64622e8e@imgtec.com> Date: Thu, 10 Aug 2017 17:00:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.107] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, On 09/08/17 23:23, James Hogan wrote: > On 9 August 2017 10:35:39 BST, Harvey Hunt wrote: >> From: John Crispin >> >> Add a driver to setup the USB phy on Mediatek/Ralink SoCs. >> The driver is trivial and only sets up power and host mode. >> >> Signed-off-by: John Crispin >> Signed-off-by: Harvey Hunt >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-mediatek@lists.infradead.org >> --- >> Changes in V4 >> * Remove Allwinner from comment >> * Depend on COMPILE_TEST >> >> Changes in V3 >> * Separate DT bindings >> * Update Kconfig text >> * Modify John's email address >> * Rebase onto v4.13-rc3 >> >> Changes in V2 >> * remove refcounting >> * drop empty functions >> * dont use static globals >> * use explicit compatible strings >> >> drivers/phy/Kconfig | 8 ++ >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-ralink-usb.c | 173 >> +++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 182 insertions(+) >> create mode 100644 drivers/phy/phy-ralink-usb.c >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index c1807d4..8fb5260 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -41,6 +41,14 @@ config PHY_PISTACHIO_USB >> help >> Enable this to support the USB2.0 PHY on the IMG Pistachio SoC. >> >> +config PHY_RALINK_USB >> + tristate "Ralink USB PHY driver" >> + select GENERIC_PHY >> + depends on RALINK || COMPILE_TEST > > given that the driver includes a asm/mach-ralink header, the COMPILE_TEST bit may break x86 allmodconfig? > > maybe the header should be moved out of arch/mips or it should depend on MIPS only (so a mips allmodconfig catches it, but cant be enabled on x86 even with COMPILE_TEST=y) > > cheers > James > [...] Well spotted - the build does indeed fail for ARCH=x86 allmodconfig. I could either use: depends on RALINK || (COMPILE_TEST && MIPS) or just drop the COMPILE_TEST altogether, as I don't know how many people are running compile test only on MIPS. Thanks, Harvey