linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Dan Murphy <dmurphy@ti.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	andrew@lunn.ch, bunk@kernel.org
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, grygorii.strashko@ti.com
Subject: Re: [PATCH net-master 1/1] net: phy: dp83867: Add speed optimization feature
Date: Fri, 31 Jan 2020 20:57:14 -0800	[thread overview]
Message-ID: <2116231e-2373-6511-da06-32ea01266b49@gmail.com> (raw)
In-Reply-To: <27ab4feb-fe84-4d3b-1779-25a25065a9fa@ti.com>



On 1/31/2020 5:30 PM, Dan Murphy wrote:
> Heiner
> 
> On 1/31/20 2:56 PM, Heiner Kallweit wrote:
>> On 31.01.2020 16:11, Dan Murphy wrote:
>>> Set the speed optimization bit on the DP83867 PHY.
>>> This feature can also be strapped on the 64 pin PHY devices
>>> but the 48 pin devices do not have the strap pin available to enable
>>> this feature in the hardware.  PHY team suggests to have this bit set.
>>>
>> It's ok to enable downshift by default, however it would be good to
>> make it configurable. Best implement the downshift tunable, you can
>> use the Marvell PHY driver as reference.
>> Can the number of attempts until downshifts happens be configured?
> 
> Yes we can tune the number of attempts it makes to negotiate 1000Mbps
> before enabling the speed optimization.  But why would we need to
> configure the number of attempts currently it is defaulted to 4.  Is
> there a use case for this level of configurability?

Some customers may prefer a fast(er) link re-negotiation once they know
the cabling is faulty or sub-optimal. The default is usually fine, and
if you want to support the downshift ethtool tunable when net-next opens
back up, that would be a welcome addition.
-- 
Florian

      reply	other threads:[~2020-02-01  4:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 15:11 [PATCH net-master 0/1] DP83867 Speed " Dan Murphy
2020-01-31 15:11 ` [PATCH net-master 1/1] net: phy: dp83867: Add speed " Dan Murphy
2020-01-31 17:10   ` Jakub Kicinski
2020-01-31 17:14     ` Dan Murphy
2020-01-31 18:11       ` Jakub Kicinski
2020-01-31 18:36         ` Dan Murphy
2020-01-31 17:49   ` Florian Fainelli
2020-01-31 18:29     ` Dan Murphy
2020-01-31 18:42       ` Florian Fainelli
2020-01-31 19:14         ` Dan Murphy
2020-01-31 19:29           ` Florian Fainelli
2020-01-31 19:54             ` Dan Murphy
2020-01-31 20:02               ` Florian Fainelli
2020-01-31 20:10                 ` Dan Murphy
2020-01-31 20:56   ` Heiner Kallweit
2020-02-01  1:30     ` Dan Murphy
2020-02-01  4:57       ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2116231e-2373-6511-da06-32ea01266b49@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=bunk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-master 1/1] net: phy: dp83867: Add speed optimization feature' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).