From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64884C433E2 for ; Sun, 6 Sep 2020 22:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DD8320C09 for ; Sun, 6 Sep 2020 22:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbgIFWpu (ORCPT ); Sun, 6 Sep 2020 18:45:50 -0400 Received: from gloria.sntech.de ([185.11.138.130]:38430 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbgIFWpt (ORCPT ); Sun, 6 Sep 2020 18:45:49 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF3Pu-0002dv-0j; Mon, 07 Sep 2020 00:45:46 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Elaine Zhang Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, xxx@rock-chips.com, xf@rock-chips.com, huangtao@rock-chips.com, kever.yang@rock-chips.com, Elaine Zhang Subject: Re: [PATCH v3 4/6] clk: rockchip: Export some clock common APIs for module drivers Date: Mon, 07 Sep 2020 00:45:45 +0200 Message-ID: <2117462.I4v89iqCCR@diego> In-Reply-To: <20200904074405.24439-5-zhangqing@rock-chips.com> References: <20200904074405.24439-1-zhangqing@rock-chips.com> <20200904074405.24439-5-zhangqing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 4. September 2020, 09:44:03 CEST schrieb Elaine Zhang: > This is used by the Rockchip clk driver, export it to allow that > driver to be compiled as a module. > > Signed-off-by: Elaine Zhang > Reviewed-by: Kever Yang > --- > drivers/clk/rockchip/clk.c | 52 ++++++++++++++++++++++---------------- > 1 file changed, 30 insertions(+), 22 deletions(-) > > diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c > index 46409972983e..fd3aff2a599d 100644 > --- a/drivers/clk/rockchip/clk.c > +++ b/drivers/clk/rockchip/clk.c > @@ -360,8 +360,9 @@ static struct clk *rockchip_clk_register_factor_branch(const char *name, > return hw->clk; > } > > -struct rockchip_clk_provider * __init rockchip_clk_init(struct device_node *np, > - void __iomem *base, unsigned long nr_clks) > +struct rockchip_clk_provider *rockchip_clk_init(struct device_node *np, > + void __iomem *base, > + unsigned long nr_clks) > { > struct rockchip_clk_provider *ctx; > struct clk **clk_table; > @@ -393,14 +394,16 @@ struct rockchip_clk_provider * __init rockchip_clk_init(struct device_node *np, > kfree(ctx); > return ERR_PTR(-ENOMEM); > } > +EXPORT_SYMBOL(rockchip_clk_init); again, same comment about EXPORT_SYMBOL_GPL