[PATCH] fs/ntfs3: make ntfs3 compile with clang-12

[PATCH] fs/ntfs3: make ntfs3 compile with clang-12

[torvic9]

Some of the ccflags in the fs/ntfs3 Makefile are for gcc only.
Replace them with clang alternatives if necessary.

Signed-off-by: Tor Vic <torvic9@mailbox.org>
---
 fs/ntfs3/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/ntfs3/Makefile b/fs/ntfs3/Makefile
index b06a06cc0..dae144033 100644
--- a/fs/ntfs3/Makefile
+++ b/fs/ntfs3/Makefile
@@ -4,7 +4,9 @@
 #
 
 # to check robot warnings
-ccflags-y += -Wunused-but-set-variable -Wold-style-declaration -Wint-to-pointer-cast
+ccflags-y += -Wint-to-pointer-cast \
+	$(call cc-option,-Wunused-but-set-variable,-Wunused-const-variable) \
+	$(call cc-option,-Wold-style-declaration,-Wout-of-line-declaration)
 
 obj-$(CONFIG_NTFS3_FS) += ntfs3.o
 
-- 
2.31.1

Re: [PATCH] fs/ntfs3: make ntfs3 compile with clang-12

[Nick Desaulniers]

On Wed, May 19, 2021 at 6:43 AM <torvic9@mailbox.org> wrote:
>
> Some of the ccflags in the fs/ntfs3 Makefile are for gcc only.
> Replace them with clang alternatives if necessary.
>
> Signed-off-by: Tor Vic <torvic9@mailbox.org>

Thanks for the patch. +clang-built-linux; please make sure to cc the
lists from ./scripts/get_maintainer.pl <patch file>.  It should
recommend our mailing list of the words clang or llvm appear anywhere
in the patch file. This helps spread around the review burden.

> ---
>  fs/ntfs3/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ntfs3/Makefile b/fs/ntfs3/Makefile
> index b06a06cc0..dae144033 100644
> --- a/fs/ntfs3/Makefile
> +++ b/fs/ntfs3/Makefile
> @@ -4,7 +4,9 @@
>  #
>
>  # to check robot warnings
> -ccflags-y += -Wunused-but-set-variable -Wold-style-declaration -Wint-to-pointer-cast
> +ccflags-y += -Wint-to-pointer-cast \
> +       $(call cc-option,-Wunused-but-set-variable,-Wunused-const-variable) \
> +       $(call cc-option,-Wold-style-declaration,-Wout-of-line-declaration)

I think it would be better to leave off the second parameter of both
of these, which is the fallback.

>
>  obj-$(CONFIG_NTFS3_FS) += ntfs3.o
>
> --
> 2.31.1

-- 
Thanks,
~Nick Desaulniers

Re: [PATCH] fs/ntfs3: make ntfs3 compile with clang-12

[torvic9]

> Nick Desaulniers <ndesaulniers@google.com> hat am 20.05.2021 01:06 geschrieben:
> 
>  
> On Wed, May 19, 2021 at 6:43 AM <torvic9@mailbox.org> wrote:
> >
> > Some of the ccflags in the fs/ntfs3 Makefile are for gcc only.
> > Replace them with clang alternatives if necessary.
> >
> > Signed-off-by: Tor Vic <torvic9@mailbox.org>
> 
> Thanks for the patch. +clang-built-linux; please make sure to cc the
> lists from ./scripts/get_maintainer.pl <patch file>.  It should
> recommend our mailing list of the words clang or llvm appear anywhere
> in the patch file. This helps spread around the review burden.
> 

Cool, I didn't know about that script, thanks!

> > ---
> >  fs/ntfs3/Makefile | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/ntfs3/Makefile b/fs/ntfs3/Makefile
> > index b06a06cc0..dae144033 100644
> > --- a/fs/ntfs3/Makefile
> > +++ b/fs/ntfs3/Makefile
> > @@ -4,7 +4,9 @@
> >  #
> >
> >  # to check robot warnings
> > -ccflags-y += -Wunused-but-set-variable -Wold-style-declaration -Wint-to-pointer-cast
> > +ccflags-y += -Wint-to-pointer-cast \
> > +       $(call cc-option,-Wunused-but-set-variable,-Wunused-const-variable) \
> > +       $(call cc-option,-Wold-style-declaration,-Wout-of-line-declaration)
> 
> I think it would be better to leave off the second parameter of both
> of these, which is the fallback.

OK, I will do that.
Thanks for your feedback!

> 
> >
> >  obj-$(CONFIG_NTFS3_FS) += ntfs3.o
> >
> > --
> > 2.31.1
> 
> -- 
> Thanks,
> ~Nick Desaulniers