From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756779AbdDQPeZ (ORCPT ); Mon, 17 Apr 2017 11:34:25 -0400 Received: from mout.web.de ([212.227.17.12]:50315 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754508AbdDQPeX (ORCPT ); Mon, 17 Apr 2017 11:34:23 -0400 Subject: [PATCH 24/25] skge: Adjust a null pointer check in skge_down() From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <2122f892-68a6-e9cc-d15e-e82e62fc50b9@users.sourceforge.net> Date: Mon, 17 Apr 2017 17:34:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:arivhG0ydntB/ngVwheJ3Lrce1Imv/E+Mf+Tqf5hwMhCttV+0cx 4im1ur7VgIMEPFMEataYY/TeOrY57eIb5o8XE0QmaRQHW2b7Du6+IZ0nL6ab54wNn1s9LGz YY+RTEo1egVbQTo4tgpoa3mZhBvNBb8F+tcx0pTOuyOLnCDogxDU7J7sczLJUDK+Zi5vpQx N3Y4niB3Y4l1SsKjJbV9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:zFQY4hNDiWU=:zZs8XitjpMZTc6bpuyFYag oUGCpJinBTZ4QTzuOJsJoapSPvo2nxR6dLRWN7IMNy1pGYXs9XSORatwv4XGOg07PoiLewqix e6EAwT0fAA3dHiIBg04XWULBr1inPbi9by+ebENLIjMaL8kHAqO1qCaenHi86sDDOQJUkEbSS 4t7I9XGtObNLOjkEQLqMNeH4LV/+Z5tEjEXnBUjjqYT5gJmXHEf3fdM4erDF3xeZkkbCHyZJq JttU4uvgA762I7sXKEl96+r0IdVkObMgGDGzgibd69VVWGBb4NZqn+C8RLoSYhraC8rLQz8to WjfuZ0w7RAYC4EGC0qHyJreafMr0zs72ogBJEBdd8FeC4+I4Bv0wqOPiW1KhhOd2BZbRJE3o5 7j9hJfCLJuBcb8/7MFS0Xe5Lw6czZ1T26Mahr56uwostu+UrF1sVVM6DZCgld3cqWoYg1Zt4A luF9IRA4TXNkJbqWCWBuRgcpiGJi6loeDDu/7+U89KxARDQRxznPTvKE4UKpLJTUGzW1kpZnj J37bZeN2wMOwF0hSmYgsa1Y5a8JPW33D57Wku2rObGF0K3F/kvzOan0bx7U6337LsM/MblWVd stj2+0e+PYAfIKQuotlCMzYWtW/7K3Zj2AqRWZDt/ZZvLnOFLYN5hyEkV6fd7t2C91jSCjgy3 j0DYuuoCjENf6Cm/GjoRoHT5ZGmSzHbgLW/k9r6O74dK9HI32jFZgxYqb6r4CH5eARXb2osFX ZRKQ4BGip53weYAPxziepZjnlj5q7ns80yliQV9kVGkYeTznexUR4ZJZ1O1XxAvw2KE5kNZdY s1fhT/b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 17 Apr 2017 16:08:39 +0200 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "!skge->mem". Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/skge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 90bfdbcfd910..5d7d94de4e00 100644 --- a/drivers/net/ethernet/marvell/skge.c +++ b/drivers/net/ethernet/marvell/skge.c @@ -2657,7 +2657,7 @@ static int skge_down(struct net_device *dev) struct skge_hw *hw = skge->hw; int port = skge->port; - if (skge->mem == NULL) + if (!skge->mem) return 0; netif_info(skge, ifdown, skge->netdev, "disabling interface\n"); -- 2.12.2