From: Marcel Holtmann <marcel@holtmann.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Linux Bluetooth mailing list <linux-bluetooth@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Balakrishna Godavarthi <bgodavar@codeaurora.org>,
Harish Bandi <c-hbandi@codeaurora.org>,
Rocky Liao <rjliao@codeaurora.org>
Subject: Re: [PATCH] Bluetooth: btqca: Add a short delay before downloading the NVM
Date: Thu, 11 Jul 2019 09:06:45 +0200 [thread overview]
Message-ID: <21246F6F-ADF5-4D05-8690-D0ABD793BA64@holtmann.org> (raw)
In-Reply-To: <20190709224450.187737-1-mka@chromium.org>
Hi Matthias,
> On WCN3990 downloading the NVM sometimes fails with a "TLV response
> size mismatch" error:
>
> [ 174.949955] Bluetooth: btqca.c:qca_download_firmware() hci0: QCA Downloading qca/crnv21.bin
> [ 174.958718] Bluetooth: btqca.c:qca_tlv_send_segment() hci0: QCA TLV response size mismatch
>
> It seems the controller needs a short time after downloading the
> firmware before it is ready for the NVM. A delay as short as 1 ms
> seems sufficient, make it 10 ms just in case. No event is received
> during the delay, hence we don't just silently drop an extra event.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> I'm only guessing why the delay is needed, maybe QCA folks can shed
> more light on this.
>
> I didn't see this error when testing 2faa3f15fa2f ("Bluetooth: hci_qca:
> wcn3990: Drop baudrate change vendor event") and 32646db8cc28
> ("Bluetooth: btqca: inject command complete event during fw download")
> intensively a few months ago. My guess is that some changes in the kernel
> (I test with a 4.19 kernel with regular -stable merges) altered the
> timing, which made this issue visible.
> ---
> drivers/bluetooth/btqca.c | 3 +++
> 1 file changed, 3 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2019-07-11 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 22:44 [PATCH] Bluetooth: btqca: Add a short delay before downloading the NVM Matthias Kaehlcke
2019-07-11 7:06 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21246F6F-ADF5-4D05-8690-D0ABD793BA64@holtmann.org \
--to=marcel@holtmann.org \
--cc=bgodavar@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).